Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add redrawReglTraces subroutine #3067

Merged
merged 7 commits into from
Oct 2, 2018
Merged

Add redrawReglTraces subroutine #3067

merged 7 commits into from
Oct 2, 2018

Commits on Oct 2, 2018

  1. introduce redrawReglTraces subroutine 

    - which (re)-draw scattergl, scatterpolargl, splom traces as well as
  splom regl grid line in one go, always in the correct order
- packaging these gl draw calls in one subroutine is especially
  useful for drag and selections, where buffers of targeted traces/scene
  are updated, but *all* traces need to be redraw following clearGlCanvases
    @etpinard
    etpinard committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    81eb48b View commit details
    Browse the repository at this point in the history

  2. 🔪 obsolete sortBasePlotModules 

    ... no need for this now that we have redrawReglTraces
    @etpinard
    etpinard committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    0243451 View commit details
    Browse the repository at this point in the history

  3. use redrawReglTraces on drag

    @etpinard
    etpinard committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    dcacd78 View commit details
    Browse the repository at this point in the history

  4. use redrawReglTraces on polar drag

    @etpinard
    etpinard committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    68dfbc1 View commit details
    Browse the repository at this point in the history

  5. fix #2797 - clear full canvas and use redrawReglTraces on selections 

    - no longer need _module.styleOnSelect!
- selections on overlaid subplots now work!
- remove clearViewport (for now), we could bring it back
  again to optimize selections on disjoint subplots.
    @etpinard
    etpinard committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    c02330c View commit details
    Browse the repository at this point in the history

  6. use redrawReglTraces in edit subroutines

    @etpinard
    etpinard committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    02263b9 View commit details
    Browse the repository at this point in the history

  7. skip canvas/context size mismatch test on CI

    @etpinard
    etpinard committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    f179c2f View commit details
    Browse the repository at this point in the history