fix(utils): revert subscribeKey impl to the original one (without ops) (

#554) * Add test for subscribeKey and proxyWithComputed * refactor test * revert subscribeKey with old impl Co-authored-by: Luke Barlow <[email protected]>
pmndrs · Oct 7, 2022 · fc12e01 · fc12e01 · vercel · Oct 7, 2022
1 parent 6e58c9d
commit fc12e01
Show file tree

Hide file tree

Showing 2 changed files with 271 additions and 247 deletions.
diff --git a/src/utils/subscribeKey.ts b/src/utils/subscribeKey.ts
@@ -17,11 +17,13 @@ export function subscribeKey<T extends object, K extends keyof T>(
   callback: (value: T[K]) => void,
   notifyInSync?: boolean
 ) {
+  let prevValue = proxyObject[key]
   return subscribe(
     proxyObject,
-    (ops) => {
-      if (ops.some((op) => op[1][0] === key)) {
-        callback(proxyObject[key])
+    () => {
+      const nextValue = proxyObject[key]
+      if (!Object.is(prevValue, nextValue)) {
+        callback((prevValue = nextValue))
       }
     },
     notifyInSync