Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): revert subscribeKey impl to the original one (without ops) #554

Merged
merged 3 commits into from
Oct 7, 2022

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Sep 23, 2022

close #350

@vercel
Copy link

vercel bot commented Sep 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
valtio ✅ Ready (Inspect) Visit Preview Sep 23, 2022 at 2:20AM (UTC)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d6c2930:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration

@github-actions
Copy link

Size Change: +81 B (0%)

Total Size: 50 kB

Filename Size Change
dist/esm/utils.js 4.13 kB +22 B (+1%)
dist/system/utils.development.js 4.35 kB +26 B (+1%)
dist/system/utils.production.js 2.91 kB +2 B (0%)
dist/umd/utils.development.js 4.86 kB +12 B (0%)
dist/umd/utils.production.js 3.09 kB +5 B (0%)
dist/utils.js 4.71 kB +14 B (0%)
ℹ️ View Unchanged
Filename Size
dist/esm/index.js 731 B
dist/esm/macro.js 617 B
dist/esm/macro/vite.js 732 B
dist/esm/vanilla.js 1.98 kB
dist/index.js 883 B
dist/macro.js 910 B
dist/macro/vite.js 1.04 kB
dist/system/index.development.js 894 B
dist/system/index.production.js 512 B
dist/system/macro.development.js 725 B
dist/system/macro.production.js 555 B
dist/system/macro/vite.development.js 839 B
dist/system/macro/vite.production.js 660 B
dist/system/vanilla.development.js 2.09 kB
dist/system/vanilla.production.js 1.29 kB
dist/umd/index.development.js 1.01 kB
dist/umd/index.production.js 671 B
dist/umd/macro.development.js 1.06 kB
dist/umd/macro.production.js 766 B
dist/umd/macro/vite.development.js 1.21 kB
dist/umd/macro/vite.production.js 893 B
dist/umd/vanilla.development.js 2.29 kB
dist/umd/vanilla.production.js 1.39 kB
dist/vanilla.js 2.19 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proxyWithComputed and subscribeKey
2 participants