Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of function selectors #47

Merged
merged 3 commits into from
Dec 9, 2020
Merged

Fix parsing of function selectors #47

merged 3 commits into from
Dec 9, 2020

Conversation

ayrat555
Copy link
Collaborator

@ayrat555 ayrat555 commented Dec 8, 2020 •
edited
Loading

Changes:

  • Function selector parsing fails on user-defined complex types (6ffcd54)
  • Fix parsing of fixed tuple array (0b4aee7)

fixes #46

@ayrat555
Do not fail when parsing user defined types
6ffcd54 
Function selector parsing fails on user defined comples types
@ayrat555 ayrat555 marked this pull request as draft December 8, 2020 12:31
@ayrat555 ayrat555 changed the title Do not fail when parsing user defined types Fix parsing of function selectors Dec 9, 2020
@ayrat555 ayrat555 marked this pull request as ready for review December 9, 2020 10:43
InoMurko
InoMurko approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@InoMurko InoMurko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, as per conversation:
if stuff is being skipped from the ABI definition it would be good to Logger.warn the user

it probably makes sense to split #46 and leave an open issue for the stuff that's still not supported

@ayrat555 ayrat555 merged commit c2c3528 into master Dec 9, 2020
@ayrat555 ayrat555 deleted the ayrat555/do-no-parse-complex-types branch December 9, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InoMurko InoMurko InoMurko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

abi parsing from json
2 participants
@ayrat555 @InoMurko