Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of function selectors #47

Merged
merged 3 commits into from
Dec 9, 2020
Merged

Fix parsing of function selectors #47

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ffcd54
Do not fail when parsing user defined types
ayrat555 Dec 8, 2020
0b4aee7
Fix parsing of fixed tuple arrays
ayrat555 Dec 9, 2020
b71c4eb
add logging
ayrat555 Dec 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
156 changes: 107 additions & 49 deletions lib/abi/function_selector.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,19 @@ defmodule ABI.FunctionSelector do
returns: []
]

@simple_types [
"uint",
"int",
"address",
"bool",
"fixed",
"uint",
"ufixed",
"bytes",
"string",
"tuple"
]

@doc """
Decodes a function selector to a struct.

Expand Down Expand Up @@ -150,64 +163,72 @@ defmodule ABI.FunctionSelector do

@doc false
def parse_specification_item(%{"type" => "function"} = item) do
%{
"name" => function_name,
"inputs" => named_inputs,
"outputs" => named_outputs
} = item

input_types = Enum.map(named_inputs, &parse_specification_type/1)
input_names = Enum.map(named_inputs, &Map.get(&1, "name"))

output_types = Enum.map(named_outputs, &parse_specification_type/1)

selector = %ABI.FunctionSelector{
function: function_name,
types: input_types,
returns: output_types,
input_names: input_names,
type: :function
}
with %{
"name" => function_name,
"inputs" => named_inputs,
"outputs" => named_outputs
} <- item,
true <- simple_types?(named_inputs),
true <- simple_types?(named_outputs) do
input_types = Enum.map(named_inputs, &parse_specification_type/1)
input_names = Enum.map(named_inputs, &Map.get(&1, "name"))

output_types = Enum.map(named_outputs, &parse_specification_type/1)

selector = %ABI.FunctionSelector{
function: function_name,
types: input_types,
returns: output_types,
input_names: input_names,
type: :function
}

add_method_id(selector)
add_method_id(selector)
else
_ -> nil
end
end

def parse_specification_item(%{"type" => "constructor"} = item) do
%{
"inputs" => named_inputs
} = item

input_types = Enum.map(named_inputs, &parse_specification_type/1)
input_names = Enum.map(named_inputs, &Map.get(&1, "name"))

selector = %ABI.FunctionSelector{
types: input_types,
input_names: input_names,
type: :constructor
}
with %{"inputs" => named_inputs} <- item,
true <- simple_types?(named_inputs) do
input_types = Enum.map(named_inputs, &parse_specification_type/1)
input_names = Enum.map(named_inputs, &Map.get(&1, "name"))

selector = %ABI.FunctionSelector{
types: input_types,
input_names: input_names,
type: :constructor
}

add_method_id(selector)
add_method_id(selector)
else
_ -> nil
end
end

def parse_specification_item(%{"type" => "event"} = item) do
%{
"name" => event_name,
"inputs" => named_inputs
} = item

input_types = Enum.map(named_inputs, &parse_specification_type/1)
input_names = Enum.map(named_inputs, &Map.get(&1, "name"))
inputs_indexed = Enum.map(named_inputs, &Map.get(&1, "indexed"))

selector = %ABI.FunctionSelector{
function: event_name,
types: input_types,
input_names: input_names,
inputs_indexed: inputs_indexed,
type: :event
}
with %{
"name" => event_name,
"inputs" => named_inputs
} <- item,
true <- simple_types?(named_inputs) do
input_types = Enum.map(named_inputs, &parse_specification_type/1)
input_names = Enum.map(named_inputs, &Map.get(&1, "name"))
inputs_indexed = Enum.map(named_inputs, &Map.get(&1, "indexed"))

selector = %ABI.FunctionSelector{
function: event_name,
types: input_types,
input_names: input_names,
inputs_indexed: inputs_indexed,
type: :event
}

add_method_id(selector)
add_method_id(selector)
else
_ -> nil
end
end

def parse_specification_item(%{"type" => "fallback"}) do
Expand All @@ -223,6 +244,29 @@ defmodule ABI.FunctionSelector do

def parse_specification_item(_), do: nil

@spec simple_types?([map()]) :: boolean()
def simple_types?([]), do: true

def simple_types?([%{"type" => tuple_type, "components" => current_types} | types])
when tuple_type in ["tuple", "tuple[]"] do
case simple_types?(current_types) do
true -> simple_types?(types)
false -> false
end
end

def simple_types?([%{"type" => type} | types]) do
simple_type? =
Enum.any?(@simple_types, fn simple_type ->
String.contains?(type, simple_type)
end)

case simple_type? do
true -> simple_types?(types)
false -> false
end
end

@doc false
def parse_specification_type(%{"type" => "tuple", "components" => components}) do
sub_types = for component <- components, do: parse_specification_type(component)
Expand All @@ -234,6 +278,20 @@ defmodule ABI.FunctionSelector do
{:array, {:tuple, sub_types}}
end

def parse_specification_type(%{
"type" => "tuple[" <> tail,
"components" => components
}) do
sub_types = for component <- components, do: parse_specification_type(component)

size =
tail
|> String.replace("]", "")
|> String.to_integer()

{:array, {:tuple, sub_types}, size}
end

def parse_specification_type(%{"type" => type}), do: decode_type(type)

@doc """
Expand Down
Loading