Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back implementation #927

Draft
wants to merge 1 commit into
base: ibc/client-semantics-interface-only
Choose a base branch
from

Conversation

Olshansk
Copy link
Member

@Olshansk Olshansk commented Jul 21, 2023

Description

Summary generated by Reviewpad on 21 Jul 23 19:52 UTC

This pull request includes several file diffs with various changes. Here is a summary of the changes:

  • The file persistence/types/ibc.go has changes to the functions InsertIBCStoreEntryQuery, InsertIBCEventQuery, and GetIBCStoreEntryQuery, modifying the data type of the height parameter from int64 to uint64.
  • The file runtime/bus.go has a new method GetClientManager() added to the bus struct, which retrieves a modules.ClientManager module from the registry.
  • The file bulk_store_cache.go has a change in the AddStore function, where the code store := newProvableStore(s.GetBus(), coreTypes.CommitmentPrefix(name), s.privateKey) has been changed to store := NewProvableStore(s.GetBus(), coreTypes.CommitmentPrefix(name), s.privateKey).
  • The diff in the file ibc_test.go in the persistence/test directory includes several changes related to the height parameter type, function renames, and removal of event.Height assignments and assertions.
  • A new file introspect.go has been added to the ibc/client package, introducing functions related to managing the client state for the Pocket network in the context of the IBC protocol.
  • The file ibc/main_test.go has a change in the newTestP2PModule function, where the line bus.RegisterModule(p2pMock) has been removed.
  • A new file queries.go has been added to the ibc/client directory, containing functions GetConsensusState and GetClientState related to managing client information.
  • The file gov.go in the persistence package has changes to the GetRevisionNumber function, including a parameter type change and addition of TODO comments for the implementation of GetRevisionNumber and GetSupportedChains.
  • A new file ics02.md has been added to the ibc/docs directory, providing documentation for ICS-02, the client semantics in the IBC protocol.
  • The file ibc/host/submodule.go has changes related to the creation of an IBC host submodule and the initialization of its dependencies.
  • The file event_manager.go has changes to import statements, method signatures, and a new read context creation using the current height in the QueryEvents method.
  • A new file host_introspection_test.go has been added to the ibc package, containing test functions for obtaining the current height and host consensus state using the ClientManager.
  • The file client_state_paths.go has changes related to function names, parameter types, and addition of new functions.
  • The file README.md has been modified, adding a new section and updating the table of contents.
  • The file client_module.go contains the implementation of functions related to emitting events in the IBC client module.
  • The file persistence/types/ibc.go has changes to the function name and parameter types, as well as a new line of code that trims a string.
  • A new file submodule.go has been added to the ibc/client package, implementing a client manager module for the IBC protocol.

Please review these changes in the diff to ensure they align with the intended modifications.

Issue

Fixes #<issue_number>

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

Testing

  • make develop_test; if any code changes were made
  • make test_e2e on k8s LocalNet; if any code changes were made
  • e2e-devnet-test passes tests on DevNet; if any code was changed
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@reviewpad reviewpad bot added the large Pull request is large label Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant