Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Reviewpad on 21 Jul 23 19:52 UTC
This pull request includes several file diffs with various changes. Here is a summary of the changes:
persistence/types/ibc.go
has changes to the functionsInsertIBCStoreEntryQuery
,InsertIBCEventQuery
, andGetIBCStoreEntryQuery
, modifying the data type of theheight
parameter fromint64
touint64
.runtime/bus.go
has a new methodGetClientManager()
added to thebus
struct, which retrieves amodules.ClientManager
module from the registry.bulk_store_cache.go
has a change in theAddStore
function, where the codestore := newProvableStore(s.GetBus(), coreTypes.CommitmentPrefix(name), s.privateKey)
has been changed tostore := NewProvableStore(s.GetBus(), coreTypes.CommitmentPrefix(name), s.privateKey)
.ibc_test.go
in thepersistence/test
directory includes several changes related to theheight
parameter type, function renames, and removal ofevent.Height
assignments and assertions.introspect.go
has been added to theibc/client
package, introducing functions related to managing the client state for the Pocket network in the context of the IBC protocol.ibc/main_test.go
has a change in thenewTestP2PModule
function, where the linebus.RegisterModule(p2pMock)
has been removed.queries.go
has been added to theibc/client
directory, containing functionsGetConsensusState
andGetClientState
related to managing client information.gov.go
in thepersistence
package has changes to theGetRevisionNumber
function, including a parameter type change and addition of TODO comments for the implementation ofGetRevisionNumber
andGetSupportedChains
.ics02.md
has been added to theibc/docs
directory, providing documentation for ICS-02, the client semantics in the IBC protocol.ibc/host/submodule.go
has changes related to the creation of an IBC host submodule and the initialization of its dependencies.event_manager.go
has changes to import statements, method signatures, and a new read context creation using the current height in theQueryEvents
method.host_introspection_test.go
has been added to theibc
package, containing test functions for obtaining the current height and host consensus state using the ClientManager.client_state_paths.go
has changes related to function names, parameter types, and addition of new functions.README.md
has been modified, adding a new section and updating the table of contents.client_module.go
contains the implementation of functions related to emitting events in the IBC client module.persistence/types/ibc.go
has changes to the function name and parameter types, as well as a new line of code that trims a string.submodule.go
has been added to theibc/client
package, implementing a client manager module for the IBC protocol.Please review these changes in the diff to ensure they align with the intended modifications.
Issue
Fixes #<issue_number>
Type of change
Please mark the relevant option(s):
List of changes
Testing
make develop_test
; if any code changes were mademake test_e2e
on k8s LocalNet; if any code changes were madee2e-devnet-test
passes tests on DevNet; if any code was changedRequired Checklist
godoc
format comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*
if I updatedshared/*
README(s)