-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Number #2
Comments
I would like to propose the use of build metadata outlined in Semver 2, so that we can have continous merging into the code while on the "same version". |
Ah, I noticed a misread in the specification which caused a flawed implementation, so this shouldn't be closed after all. Format will be edited to conform to the format -- applied to our case, version number will look something like this: |
In fact, the branch and commit don't quite fit into this scheme; the proper format should be |
What would be the actionable here @iajrz ? Creating a PR ammending the docs? |
Action items:
|
@iajrz I want to create a tag & release for main https://github.com/pokt-network/pocket as a milestone finish line. Following the instructions in https://github.com/pokt-network/pocket/tree/main/docs/build, what should it be? |
Tag |
Per https://en.wikipedia.org/wiki/Software_release_life_cycle, I'll go with pre-alpha for now, but otherwise sounds good. |
PR with documentation update here: https://github.com/pokt-network/pocket/pull/91/files |
Going to close this out given the previous version update. |
… (#159) ## Description Minor code cleanup and footprint reduction post the first major telemetry milestone in #135. ## Type of change Please mark the options that are relevant. - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation - [X] Other: Code cleanup ## How Has This Been Tested? I did a docker wipe to start on a clean slate. - [X] `make test_all` - [X] [LocalNet](https://github.com/pokt-network/pocket/blob/main/docs/development/README.md) ## Checklist - [X] I have performed a self-review of my own code - [X] I have commented my code, particularly in hard-to-understand areas - [X] I have tested my changes using the available tooling - [X] If applicable, I have made corresponding changes to related or global README - [X] If applicable, I have added added new diagrams using [mermaid.js](https://mermaid-js.github.io) - [X] If applicable, I have added tests that prove my fix is effective or that my feature works
Versions should be semver 2 compatible, which is aligned with golang's module versioning guidelines.
I think we should start work with version "0.99.0" to begin with, which is a number that points towards v1, is below 1.x (denoting "in development"), and is far enough from v0's version number to differentiate it.
The text was updated successfully, but these errors were encountered: