Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove treasury from Encointer runtime #176

Closed
brenzi opened this issue Feb 7, 2024 · 3 comments · Fixed by #270
Closed

remove treasury from Encointer runtime #176

brenzi opened this issue Feb 7, 2024 · 3 comments · Fixed by #270

Comments

@brenzi
Copy link
Contributor

brenzi commented Feb 7, 2024

Since #158, Encointer's treasury will no longer receive fees. While this is more the result of an oversight AFAIU, it may actually make sense to get rid of the treasury on the Encointer system chain altogether.

The new multi-asset treasury is way too complex for just collecting KSM fees. Yet, it is not powerful enough to be used for our plans of per-community treasuries

I suggest to simply remove the treasury pallet and ignore the negligible funds currently in the treasury (<<1KSM)
@ggwpez
Copy link
Member

ggwpez commented Feb 7, 2024

How did #158 cause this? Yea if the treasury is not used here then just remove it i guess.
But why is there only <<1KSM in? Does the chain not collect more fees?

@ggwpez ggwpez changed the title remove treasruy from Encointer runtime remove treasury from Encointer runtime Feb 7, 2024
@brenzi
Copy link
Contributor Author

brenzi commented Feb 7, 2024 •
edited
Loading

Why only << 1KSM: because almost all extrinsics are paid in community currency (thus purchasing power adjusted). These CC fees are burned. Only registering new communities needs KSM which went to treasury

#158 removed our custom deal-with-fees and replaced it with the standard systemchain impl.

TBH I haven't tested the behaviour of the new setup in all cases yet

@ggwpez
Copy link
Member

ggwpez commented Feb 7, 2024 •
edited
Loading

Okay. Yea then when its not needed maybe also remove it in #177.
Otherwise if you need more time to test stuff you can also revert #158 for Encointer, since it was indeed an oversight.

@brenzi brenzi mentioned this issue Feb 14, 2024
Closed
@brenzi brenzi mentioned this issue Apr 10, 2024
Merged
6 tasks
fellowship-merge-bot bot pushed a commit that referenced this issue May 21, 2024
@brenzi @joepetrowski
[encointer] introduce collator selection and send fees to authors ins…
2fe6f56 
…tead of treasury (#270)

closes #183 
closes #176
closes #146 (should be closed already, but this PR adds more)

This PR aligns collator selection and fee distribution logic of
Encointer with other system chains and thereby is a small step towards
[self-sustainability of
infrastructure](https://forum.polkadot.network/t/towards-encointer-self-sustainability/4195)

* [x] remove treasury (and leave negligible funds on trsry account)
* [x] add collator-selection, session and authorship pallets
* [x] instead of burning fees in community currency , send them to block
authors like native KSM
* [x] remove DMP queue pallet (pure cleanup, no change in functionality)
* [x] add migration to inject existing collators as invulnerables
* [x] remove applied migrations from release 1.2.0

steps to reproduce the new fee logic:
https://gist.github.com/brenzi/ca9e0c326198c73ff2dd0a2e74468053

---------

Co-authored-by: joe petrowski <[email protected]>
@brenzi brenzi closed this as completed Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@brenzi @ggwpez