Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually Lower ED #158

Merged

Conversation

joepetrowski
Copy link
Contributor

Since #115, chains do not use their local constants.rs values, so #131 did not have the desired effect.

Would suggest a special Asset Hub 1.1.1 release to get this deployed as soon as possible since a lot of applications were planning on it.

@xlc
Copy link
Contributor

xlc commented Jan 24, 2024

some high level chain specific e2e tests will caught this

@joepetrowski
Copy link
Contributor Author

some high level chain specific e2e tests will caught this

Yes I know, that's why it's one of my main priorities the next 6 months.

@joepetrowski
Copy link
Contributor Author

/merge

@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot merged commit 4e41af1 into polkadot-fellows:main Jan 25, 2024
16 checks passed
ggwpez pushed a commit that referenced this pull request Jan 25, 2024
Since #115, chains do
not use their local `constants.rs` values, so
#131 did not have the
desired effect.

Would suggest a special Asset Hub 1.1.1 release to get this deployed as
soon as possible since a lot of applications were planning on it.
@joepetrowski joepetrowski deleted the actually-fix-ed branch January 25, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants