Skip to content

Commit

Permalink
Revert "Async callbacks for processing GetColumnProfile RPC requests (#…
Browse files Browse the repository at this point in the history
…473)" (#513)

This reverts commit 9f864b3.
  • Loading branch information
dfalbel authored Sep 10, 2024
1 parent da7f648 commit fdafe27
Show file tree
Hide file tree
Showing 8 changed files with 366 additions and 655 deletions.
25 changes: 3 additions & 22 deletions crates/amalthea/src/comm/data_explorer_comm.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1057,26 +1057,13 @@ pub struct SetSortColumnsParams {
/// Parameters for the GetColumnProfiles method.
#[derive(Clone, Debug, Serialize, Deserialize, PartialEq)]
pub struct GetColumnProfilesParams {
/// Async callback unique identifier
pub callback_id: String,

/// Array of requested profiles
pub profiles: Vec<ColumnProfileRequest>,

/// Formatting options for returning data values as strings
pub format_options: FormatOptions,
}

/// Parameters for the ReturnColumnProfiles method.
#[derive(Clone, Debug, Serialize, Deserialize, PartialEq)]
pub struct ReturnColumnProfilesParams {
/// Async callback unique identifier
pub callback_id: String,

/// Array of individual column profile results
pub profiles: Vec<ColumnProfileResult>,
}

/**
* Backend RPC request types for the data_explorer comm
*/
Expand Down Expand Up @@ -1134,10 +1121,9 @@ pub enum DataExplorerBackendRequest {
#[serde(rename = "set_sort_columns")]
SetSortColumns(SetSortColumnsParams),

/// Async request a batch of column profiles
/// Request a batch of column profiles
///
/// Async request for a statistical summary or data profile for batch of
/// columns
/// Requests a statistical summary or data profile for batch of columns
#[serde(rename = "get_column_profiles")]
GetColumnProfiles(GetColumnProfilesParams),

Expand Down Expand Up @@ -1178,8 +1164,7 @@ pub enum DataExplorerBackendReply {
/// Reply for the set_sort_columns method (no result)
SetSortColumnsReply(),

/// Reply for the get_column_profiles method (no result)
GetColumnProfilesReply(),
GetColumnProfilesReply(Vec<ColumnProfileResult>),

/// The current backend state for the data explorer
GetStateReply(BackendState),
Expand Down Expand Up @@ -1217,9 +1202,5 @@ pub enum DataExplorerFrontendEvent {
#[serde(rename = "data_update")]
DataUpdate,

/// Return async result of get_column_profiles request
#[serde(rename = "return_column_profiles")]
ReturnColumnProfiles(ReturnColumnProfilesParams),

}

308 changes: 0 additions & 308 deletions crates/ark/src/data_explorer/column_profile.rs

This file was deleted.

2 changes: 0 additions & 2 deletions crates/ark/src/data_explorer/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,9 @@
//
//

pub mod column_profile;
pub mod export_selection;
pub mod format;
pub mod histogram;
pub mod r_data_explorer;
pub mod summary_stats;
pub mod table;
pub mod utils;
Loading

0 comments on commit fdafe27

Please sign in to comment.