Revert "Async callbacks for processing GetColumnProfile RPC requests" #513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #473
After merging #473, I bumped the Ark version and tried that version in posit-dev/positron#4326 (CI was failing before because it required the R changes). Turns out that removing the R failures uncovered some issues with the Python implementation that only happen on CI.
Since we can't land posit-dev/positron#4326 right now, we'll need to revert #473, otherwise we can't bump Ark for Positron if we need to include other changes. If we bump Ark in Positron with the changes in #473 without the changes from posit-dev/positron#4326, then the Data Explorer will stop working.
@lionel- Do you have better ideas how to avoid this situation?
I think ideally we would need to be able to build ark releases from branches, and then being able to specify them for Positron PR's, so we can test the full solution on CI before merging into Ark.