Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Async callbacks for processing GetColumnProfile RPC requests" #513

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

dfalbel
Copy link
Contributor

@dfalbel dfalbel commented Sep 9, 2024

Reverts #473

After merging #473, I bumped the Ark version and tried that version in posit-dev/positron#4326 (CI was failing before because it required the R changes). Turns out that removing the R failures uncovered some issues with the Python implementation that only happen on CI.

Since we can't land posit-dev/positron#4326 right now, we'll need to revert #473, otherwise we can't bump Ark for Positron if we need to include other changes. If we bump Ark in Positron with the changes in #473 without the changes from posit-dev/positron#4326, then the Data Explorer will stop working.

@lionel- Do you have better ideas how to avoid this situation?
I think ideally we would need to be able to build ark releases from branches, and then being able to specify them for Positron PR's, so we can test the full solution on CI before merging into Ark.

@lionel-
Copy link
Contributor

lionel- commented Sep 10, 2024

I think ideally we would need to be able to build ark releases from branches, and then being able to specify them for Positron PR's, so we can test the full solution on CI before merging into Ark.

@dfalbel Good question, I was wondering the same in another context!

I think ideally we'd support specifying a github branch of ark in a file somewhere in the positron repo, and then CI would detect it and build ark from there (very few lines of shell are needed to set up and launch an ark build) and use the resulting binary instead of a release build. This setup would be less heavy than having to do ark releases just for testing.

@lionel- lionel- merged commit fdafe27 into main Sep 10, 2024
3 checks passed
@lionel- lionel- deleted the revert-473-feature/async-callbacks branch September 10, 2024 07:35
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants