-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Move into New Window action bar button to Data Explorer #4810
Conversation
When docking a previously popped out DataExplorer back into the main window's editor tab bar, it maximizes the Panel making it look like all editors disappeared? |
While there are some other issues around editors and their context menus for moving into windows, etc, these are unrelated to this PR and we can address those later. |
That issue doesn't appear to be related to the work in this PR. I put the popped-out Data Explorer back into the main window by closing it: Uploading Screen Recording 2024-09-24 at 7.26.47 PM.mov… Dragging it back is pretty broken. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New button works well, thanks! The issues around vscode editor tab pop out windows seem to have existed previously so considering those as separate and not part of this PR.
e151ad3
to
49e1e92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that the problems I am experiencing dragging back are not related to this PR, but I do think it feels pretty broken. Would it be appropriate to put this behind a feature flag until we can get the experience as a whole more functional? I don't think it will be that uncommon to want to dock it back again.
Description
This PR addresses #3839 by adding a "Move into New Window" button to the Data Explorer Action Bar.
The button is enabled when Data Explorer is in the main window.
Here's a screen capture of the feature:
Screen.Recording.2024-09-24.at.6.26.54.PM.mov
QA Notes
None.