Merge pull request #192 from ppfeufer/fix-empty-string-check

ppfeufer · Apr 5, 2024 · 4de939c · 4de939c
2 parents f7fa1cd + 67ca73f
commit 4de939c
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -35,6 +35,12 @@ Section Order:
 ### Security
 -->
 
+## \[3.0.2\] - 2024-04-05
+
+### Fixed
+
+- Empty string checks in JS
+
 ## \[3.0.1\] - 2024-04-05
 
 ### Added

diff --git a/fleetpings/__init__.py b/fleetpings/__init__.py
@@ -6,5 +6,5 @@
 # Django
 from django.utils.translation import gettext_lazy as _
 
-__version__ = "3.0.1"
+__version__ = "3.0.2"
 __title__ = _("Fleet Pings")
diff --git a/fleetpings/static/fleetpings/js/fleetpings.js b/fleetpings/static/fleetpings/js/fleetpings.js
@@ -107,7 +107,7 @@ $(document).ready(() => {
 
         // Formup locations
         getDataFromAjaxUrl(fleetpingsSettings.url.formupLocations).then(formupLocations => {
-            if (formupLocations !== '') {
+            if (formupLocations.trim() !== '') {
                 $(fleetpingsVars.inputFormupLocation).after(formupLocations);
 
                 const optsFormupLocation = Object.assign(
@@ -129,7 +129,7 @@ $(document).ready(() => {
 
         // Fleet comms
         getDataFromAjaxUrl(fleetpingsSettings.url.fleetComms).then(fleetComms => {
-            if (fleetComms !== '') {
+            if (fleetComms.trim() !== '') {
                 $(fleetpingsVars.inputFleetComms).after(fleetComms);
 
                 const optsFleetComms = Object.assign(
@@ -151,7 +151,7 @@ $(document).ready(() => {
 
         // Fleet doctrines
         getDataFromAjaxUrl(fleetpingsSettings.url.fleetDoctrines).then(fleetDoctrines => {
-            if (fleetDoctrines !== '') {
+            if (fleetDoctrines.trim() !== '') {
                 $(fleetpingsVars.inputFleetDoctrine).after(fleetDoctrines);
 
                 const optsFleetDoctrine = Object.assign(

diff --git a/fleetpings/static/fleetpings/js/fleetpings.min.js b/fleetpings/static/fleetpings/js/fleetpings.min.js