Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Empty string checks #192

Merged
merged 1 commit into from
Apr 5, 2024
Merged

[FIX] Empty string checks #192

merged 1 commit into from
Apr 5, 2024

Conversation

ppfeufer
Copy link
Owner

@ppfeufer ppfeufer commented Apr 5, 2024

Description

Fixed

  • Empty string checks in JS

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have checked my code and corrected any misspellings

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Merging #192 (67ca73f) into master (f7fa1cd) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #192   +/-   ##
=======================================
  Coverage   76.90%   76.90%           
=======================================
  Files          15       15           
  Lines         619      619           
  Branches       59       59           
=======================================
  Hits          476      476           
  Misses        130      130           
  Partials       13       13           
Files Coverage Δ
fleetpings/__init__.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7fa1cd...67ca73f. Read the comment docs.

@ppfeufer ppfeufer marked this pull request as ready for review April 5, 2024 16:00
@ppfeufer ppfeufer merged commit 4de939c into master Apr 5, 2024
89 checks passed
@ppfeufer ppfeufer deleted the fix-empty-string-check branch April 5, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant