Skip to content

Commit

Permalink
Use 'allow_vendor_change=yes' with DNF5
Browse files Browse the repository at this point in the history
The `allow_vendor_change=no` option is going to be set in DNF5 as
default: rpm-software-management/dnf5#712

With Mock though, it is very common to override the distro default
package with a custom one (newer or fixed one?).  And blindly trying to
keep the Vendor tag unchanged for the overridden packages would be very
complicated, without any real benefits.

Note `allow_vendor_change=no` only affects the cases when some package
in the buildroot/bootstrap needs to be _updated_ while _typically_ all
the packages are only _installed_ at the beginning and are already
up2date.  This is therefore mainly related to the --chain option, or
cases like `bootstrap_image_ready=False`, `update_before_build`, the
feature in rpm-software-management#1159, etc.

Fixes: rpm-software-management#1155
  • Loading branch information
praiskup committed Jul 24, 2023
1 parent 01e8cc4 commit faf2e19
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mock/py/mockbuild/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ def setup_default_config_opts():

config_opts['dnf5_command'] = '/usr/bin/dnf5'
config_opts['system_dnf5_command'] = '/usr/bin/dnf5'
config_opts['dnf5_common_opts'] = ['--setopt=deltarpm=False', '--allowerasing']
config_opts['dnf5_common_opts'] = ['--setopt=deltarpm=False', '--setopt=allow_vendor_change=yes', '--allowerasing']
config_opts['dnf5_install_command'] = 'install dnf5 dnf5-plugins'
config_opts['dnf5_disable_plugins'] = []
# No --allowerasing with remove, per
Expand Down

0 comments on commit faf2e19

Please sign in to comment.