Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock should use dnf --setopt=allow_vendor_change=yes #1155

Closed
praiskup opened this issue Jul 20, 2023 · 0 comments · Fixed by #1160
Closed

Mock should use dnf --setopt=allow_vendor_change=yes #1155

praiskup opened this issue Jul 20, 2023 · 0 comments · Fixed by #1160
Labels
configs Issue in mock-core-configs package enhancement feature request, rfe

Comments

@praiskup
Copy link
Member

This config is going to be switched to allow_vendor_change=no by default in DNF5 (as discussed e.g. in rpm-software-management/dnf5#738), and I tend to think we should switch the default to OFF in Mock. The typical thing is to use --addrepo to provide replacement packages, or with mock --chain the local repo with results. Also Mock in Copr e.g. builds "override" packages with a different Vendor tag.

praiskup added a commit to praiskup/mock that referenced this issue Jul 24, 2023
The `allow_vendor_change=no` option is going to be set in DNF5 as
default: rpm-software-management/dnf5#712

With Mock though, it is very common to override the distro default
package with a custom one (newer or fixed one?).  And blindly trying to
keep the Vendor tag unchanged for the overridden packages would be very
complicated, without any real benefits.

Note `allow_vendor_change=no` only affects the cases when some package
in the buildroot/bootstrap needs to be _updated_ while _typically_ all
the packages are only _installed_ at the beginning and are already
up2date.  This is therefore mainly related to the --chain option, or
cases like `bootstrap_image_ready=False`, `update_before_build`, etc.

Fixes: rpm-software-management#1155
praiskup added a commit to praiskup/mock that referenced this issue Jul 24, 2023
The `allow_vendor_change=no` option is going to be set in DNF5 as
default: rpm-software-management/dnf5#712

With Mock though, it is very common to override the distro default
package with a custom one (newer or fixed one?).  And blindly trying to
keep the Vendor tag unchanged for the overridden packages would be very
complicated, without any real benefits.

Note `allow_vendor_change=no` only affects the cases when some package
in the buildroot/bootstrap needs to be _updated_ while _typically_ all
the packages are only _installed_ at the beginning and are already
up2date.  This is therefore mainly related to the --chain option, or
cases like `bootstrap_image_ready=False`, `update_before_build`, the
feature in rpm-software-management#1159, etc.

Fixes: rpm-software-management#1155
@praiskup praiskup added enhancement feature request, rfe configs Issue in mock-core-configs package labels Jul 24, 2023
praiskup added a commit to praiskup/mock that referenced this issue Jul 24, 2023
The `allow_vendor_change=no` option is going to be set in DNF5 as
default: rpm-software-management/dnf5#712

With Mock though, it is very common to override the distro default
package with a custom one (newer or fixed one?).  And blindly trying to
keep the Vendor tag unchanged for the overridden packages would be very
complicated, without any real benefits.

Note `allow_vendor_change=no` only affects the cases when some package
in the buildroot/bootstrap needs to be _updated_ while _typically_ all
the packages are only _installed_ at the beginning and are already
up2date.  This is therefore mainly related to the --chain option, or
cases like `bootstrap_image_ready=False`, `update_before_build`, the
feature in rpm-software-management#1159, etc.

Fixes: rpm-software-management#1155
praiskup added a commit to praiskup/mock that referenced this issue Jul 24, 2023
The `allow_vendor_change=no` option is going to be set in DNF5 as
default: rpm-software-management/dnf5#712
But it is also set by openSUSE with DNF4.

With Mock though, is very common to override the distro default package
with a custom one (newer or fixed packages?).  And blindly trying to
keep the Vendor tag unchanged for the overridden packages would be very
complicated task, without real benefits.

Note `allow_vendor_change=no` only affects the cases when some package
in the buildroot/bootstrap needs to be _updated_ while _typically_ all
the packages are only _installed_ at the beginning and are already
up2date.  This is therefore mainly related to the --chain option, or
cases like `bootstrap_image_ready=False`, `update_before_build`, the
feature in rpm-software-management#1159, etc.

Fixes: rpm-software-management#1155
praiskup added a commit to praiskup/mock that referenced this issue Jul 24, 2023
The `allow_vendor_change=no` option is going to be set in DNF5 as
default: rpm-software-management/dnf5#712
But it is also set by openSUSE with DNF4.

With Mock though, is very common to override the distro default package
with a custom one (newer or fixed packages?).  And blindly trying to
keep the Vendor tag unchanged for the overridden packages would be very
complicated task, without real benefits.

Note `allow_vendor_change=no` only affects the cases when some package
in the buildroot/bootstrap needs to be _updated_ while _typically_ all
the packages are only _installed_ at the beginning and are already
up2date.  This is therefore mainly related to the --chain option, or
cases like `bootstrap_image_ready=False`, `update_before_build`, the
feature in rpm-software-management#1159, etc.

Fixes: rpm-software-management#1155
praiskup added a commit that referenced this issue Jul 26, 2023
The `allow_vendor_change=no` option is going to be set in DNF5 as
default: rpm-software-management/dnf5#712
But it is also set by openSUSE with DNF4.

With Mock though, is very common to override the distro default package
with a custom one (newer or fixed packages?).  And blindly trying to
keep the Vendor tag unchanged for the overridden packages would be very
complicated task, without real benefits.

Note `allow_vendor_change=no` only affects the cases when some package
in the buildroot/bootstrap needs to be _updated_ while _typically_ all
the packages are only _installed_ at the beginning and are already
up2date.  This is therefore mainly related to the --chain option, or
cases like `bootstrap_image_ready=False`, `update_before_build`, the
feature in #1159, etc.

Fixes: #1155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configs Issue in mock-core-configs package enhancement feature request, rfe
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant