Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix message format and refactor types in SSEModel #11

Closed
wants to merge 3 commits into from

Conversation

AilurusRP
Copy link

@AilurusRP AilurusRP commented Apr 14, 2023

  1. Fixed the issue where received messages contained extra spaces at the beginning of each line and extra newline characters at the end of each message block (A possible solution for Issue#10) .
  2. Refactored the types of several fields in the SSEModel class from String? to String to avoid unnecessary null safety checks and reduce code redundancy.

These changes were tested locally and have been verified to work properly. Thank you for considering this pull request!

@pratikbaid3
Copy link
Owner

@AilurusRedPanda thanks for the fix. Can you change the destination branch to uat. There are a couple of changes there and certain improvements as well. Thanks.

@AilurusRP AilurusRP changed the base branch from master to uat April 14, 2023 08:12
@AilurusRP
Copy link
Author

AilurusRP commented Apr 14, 2023

@pratikbaid3 Thanks for your response. I have already updated the target branch to 'uat'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants