Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix message format and refactor types in SSEModel #11

Closed
wants to merge 3 commits into from
Closed

Fix message format and refactor types in SSEModel #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5f822d
fix(message-format): Remove extra space at the beginning of each line…
Apr 14, 2023
4ce1664
refactor(types): Change type of fields from to for non-nullable ini…
Apr 14, 2023
8b7fa3d
fix(message-format): Remove trailing newline characters in received m…
Apr 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions lib/flutter_client_sse.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,9 @@ class SSEClient {
var value = '';
if (field == 'data') {
//If the field is data, we get the data through the substring
value = dataLine.substring(
5,
);
value = dataLine[5] == " "
? dataLine.substring(6)
: dataLine.substring(5);
} else {
value = match.group(2) ?? '';
}
Expand All @@ -65,8 +65,9 @@ class SSEClient {
currentSSEModel.event = value;
break;
case 'data':
currentSSEModel.data =
(currentSSEModel.data ?? '') + value + '\n';
currentSSEModel.data = currentSSEModel.data.isNotEmpty
? currentSSEModel.data + "\n" + value
: value;
break;
case 'id':
currentSSEModel.id = value;
Expand Down
6 changes: 3 additions & 3 deletions lib/sse_event_model.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ part of flutter_client_sse;

class SSEModel {
//Id of the event
String? id = '';
String id = '';
//Event name
String? event = '';
String event = '';
//Event data
String? data = '';
String data = '';
SSEModel({required this.data, required this.id, required this.event});
SSEModel.fromData(String data) {
id = data.split("\n")[0].split('id:')[1];
Expand Down