Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for defaultValue in typings #2857

Closed
wants to merge 1 commit into from
Closed

Adding support for defaultValue in typings #2857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions compat/src/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,3 +126,11 @@ declare namespace React {
toArray: (children: preact.ComponentChildren) => preact.VNode<{}>[];
};
}

declare module 'preact/src/jsx' {
Copy link
Contributor Author

@Rafi993 Rafi993 Dec 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't extend JSX namespace directly in the above line so I did this do extend it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be done directly in src/jsx.d.ts

preact/src/jsx.d.ts

Line 653 in bd3c655

default?: boolean;

It's a global preact issue, not specifically a preact/compat one

Copy link
Contributor Author

@Rafi993 Rafi993 Jan 7, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. But does the preact without compact support default key?

namespace JSXInternal {
interface HTMLAttributes<RefType extends EventTarget = EventTarget> {
defaultValue?: string;
}
}
}