Adding support for defaultValue in typings #2857
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rafi993
commented
Dec 8, 2020
| @@ -126,3 +126,11 @@ declare namespace React { | |||
| toArray: (children: preact.ComponentChildren) => preact.VNode<{}>[]; | |||
| }; | |||
| } | |||
|
|
|||
| declare module 'preact/src/jsx' { | |||
There was a problem hiding this comment.
I couldn't extend JSX namespace directly in the above line so I did this do extend it.
There was a problem hiding this comment.
I think this could be done directly in src/jsx.d.ts
Line 653 in bd3c655
It's a global preact issue, not specifically a preact/compat one
There was a problem hiding this comment.
Awesome. But does the preact without compact support default key?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds support for defaultValue in typescript for HTMLElement
Related issue
Closes #2668
QA Instructions, Screenshots, Recordings
Added tests?