Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing defaultValue and defaultChecked typings #3464

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Add missing defaultValue and defaultChecked typings #3464

merged 1 commit into from
Feb 23, 2022

Conversation

ilogico
Copy link
Contributor

@ilogico ilogico commented Feb 23, 2022

fixes #2857

These attributes are necessary for working with uncontrolled forms.
Preact already works correctly with these, but the JSX typings are missing.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 99.625% when pulling b2cd4af on ilogico:support-default-attributes into 6a4b346 on preactjs:master.

JoviDeCroock
JoviDeCroock approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@JoviDeCroock JoviDeCroock merged commit 3957522 into preactjs:master Feb 23, 2022
@ilogico ilogico deleted the support-default-attributes branch April 5, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilogico @coveralls @JoviDeCroock