Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10.24.2 #4524

Merged
merged 1 commit into from
Oct 4, 2024
Merged

10.24.2 #4524

merged 1 commit into from
Oct 4, 2024

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Oct 3, 2024

Performance

Types

Maintenance

Copy link

github-actions bot commented Oct 3, 2024

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +0% (-6.01ms - +2.10ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.02ms - +0.08ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +0% (-2.16ms - +0.25ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -1% - +1% (-0.24ms - +0.18ms)
    preact-local vs preact-main
  • replace1k: slower ❌ 0% - 3% (0.04ms - 2.38ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -2% - +5% (-0.03ms - +0.09ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +0% (-0.38ms - +0.09ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -1% - +5% (-0.45ms - +1.72ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.02ms - +0.03ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +1% (-0.02ms - +0.02ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +1% (-0.43ms - +0.14ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +1% (-0.00ms - +0.04ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +2% (-0.01ms - +0.02ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +1% (-0.00ms - +0.03ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local973.02ms - 978.07ms-unsure 🔍
-1% - +0%
-6.01ms - +2.10ms
preact-main974.33ms - 980.67msunsure 🔍
-0% - +1%
-2.10ms - +6.01ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local25.37ms - 25.41ms-unsure 🔍
-0% - +0%
-0.02ms - +0.03ms
preact-main25.37ms - 25.40msunsure 🔍
-0% - +0%
-0.03ms - +0.02ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.58ms - 16.66ms-unsure 🔍
-0% - +0%
-0.02ms - +0.08ms
preact-main16.57ms - 16.61msunsure 🔍
-0% - +0%
-0.08ms - +0.02ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.67ms - 1.69ms-unsure 🔍
-1% - +1%
-0.02ms - +0.02ms
preact-main1.67ms - 1.69msunsure 🔍
-1% - +1%
-0.02ms - +0.02ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local75.06ms - 76.28ms-unsure 🔍
-3% - +0%
-2.16ms - +0.25ms
preact-main75.59ms - 77.66msunsure 🔍
-0% - +3%
-0.25ms - +2.16ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local15.37ms - 15.80ms-unsure 🔍
-3% - +1%
-0.43ms - +0.14ms
preact-main15.54ms - 15.92msunsure 🔍
-1% - +3%
-0.14ms - +0.43ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.32ms - 16.59ms-unsure 🔍
-1% - +1%
-0.24ms - +0.18ms
preact-main16.33ms - 16.64msunsure 🔍
-1% - +1%
-0.18ms - +0.24ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.59ms - 4.62ms-unsure 🔍
-0% - +1%
-0.00ms - +0.04ms
preact-main4.58ms - 4.60msunsure 🔍
-1% - +0%
-0.04ms - +0.00ms
-
replace1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local75.15ms - 77.03ms-slower ❌
0% - 3%
0.04ms - 2.38ms
preact-main74.18ms - 75.58msfaster ✔
0% - 3%
0.04ms - 2.38ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.59ms - 3.60ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-main3.59ms - 3.60msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local31.13ms - 31.88ms-unsure 🔍
-2% - +1%
-0.65ms - +0.33ms
preact-main31.36ms - 31.97msunsure 🔍
-1% - +2%
-0.33ms - +0.65ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local36.55ms - 38.07ms-unsure 🔍
-4% - +2%
-1.65ms - +0.61ms
preact-main37.00ms - 38.66msunsure 🔍
-2% - +4%
-0.61ms - +1.65ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local26.64ms - 27.07ms-unsure 🔍
-3% - +0%
-0.72ms - +0.03ms
preact-main26.89ms - 27.51msunsure 🔍
-0% - +3%
-0.03ms - +0.72ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local27.16ms - 28.32ms-unsure 🔍
-3% - +2%
-0.88ms - +0.68ms
preact-main27.32ms - 28.36msunsure 🔍
-2% - +3%
-0.68ms - +0.88ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local21.29ms - 21.80ms-unsure 🔍
-3% - +1%
-0.71ms - +0.17ms
preact-main21.46ms - 22.18msunsure 🔍
-1% - +3%
-0.17ms - +0.71ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local23.17ms - 23.60ms-unsure 🔍
-1% - +2%
-0.22ms - +0.36ms
preact-main23.13ms - 23.50msunsure 🔍
-2% - +1%
-0.36ms - +0.22ms
-
text-update

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.04ms - 2.13ms-unsure 🔍
-2% - +5%
-0.03ms - +0.09ms
preact-main2.01ms - 2.10msunsure 🔍
-4% - +2%
-0.09ms - +0.03ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.12ms - 1.12ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.12ms - 1.12msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local34.37ms - 34.65ms-unsure 🔍
-1% - +0%
-0.38ms - +0.09ms
preact-main34.46ms - 34.85msunsure 🔍
-0% - +1%
-0.09ms - +0.38ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.23ms - 1.26ms-unsure 🔍
-1% - +2%
-0.01ms - +0.02ms
preact-main1.23ms - 1.25msunsure 🔍
-2% - +1%
-0.02ms - +0.01ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local35.55ms - 37.19ms-unsure 🔍
-1% - +5%
-0.45ms - +1.72ms
preact-main35.03ms - 36.45msunsure 🔍
-5% - +1%
-1.72ms - +0.45ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.55ms - 3.57ms-unsure 🔍
-0% - +1%
-0.00ms - +0.03ms
preact-main3.54ms - 3.55msunsure 🔍
-1% - +0%
-0.03ms - +0.00ms
-

tachometer-reporter-action v2 for Benchmarks

@JoviDeCroock JoviDeCroock marked this pull request as ready for review October 3, 2024 14:59
Copy link

github-actions bot commented Oct 3, 2024

Size Change: 0 B

Total Size: 62.1 kB

ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.13 kB
compat/dist/compat.module.js 4.05 kB
compat/dist/compat.umd.js 4.19 kB
debug/dist/debug.js 3.82 kB
debug/dist/debug.module.js 3.83 kB
debug/dist/debug.umd.js 3.9 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
dist/preact.js 4.66 kB
dist/preact.min.js 4.69 kB
dist/preact.min.module.js 4.68 kB
dist/preact.min.umd.js 4.71 kB
dist/preact.module.js 4.67 kB
dist/preact.umd.js 4.73 kB
hooks/dist/hooks.js 1.53 kB
hooks/dist/hooks.module.js 1.56 kB
hooks/dist/hooks.umd.js 1.6 kB
jsx-runtime/dist/jsxRuntime.js 976 B
jsx-runtime/dist/jsxRuntime.module.js 949 B
jsx-runtime/dist/jsxRuntime.umd.js 1.05 kB
test-utils/dist/testUtils.js 451 B
test-utils/dist/testUtils.module.js 456 B
test-utils/dist/testUtils.umd.js 536 B

compressed-size-action

@coveralls
Copy link

Coverage Status

coverage: 99.488%. remained the same
when pulling fa5bd9c on 10.24.2
into 58ea2b5 on main.

@coveralls
Copy link

Coverage Status

coverage: 99.488%. remained the same
when pulling fa5bd9c on 10.24.2
into 58ea2b5 on main.

Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could merge all those CI maintenance comments into one if you think it's a bit noisy, all of them were working toward the v4 upload/download support.

@JoviDeCroock JoviDeCroock merged commit 87f7efa into main Oct 4, 2024
15 checks passed
@JoviDeCroock JoviDeCroock deleted the 10.24.2 branch October 4, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants