Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preact >= 10.18.2 compatability #528

Closed
wants to merge 14 commits into from
Closed

Preact >= 10.18.2 compatability #528

wants to merge 14 commits into from

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Nov 11, 2023 •
edited
Loading

It looks like by fixing how we copy vnodes in 10.18.2 preactjs/preact#4171 we have regressed in terms of component methods and custom-hooks.

EDIT: the first two issues are fixed however now context values get duplicated in DOM upon hot-reload... Not sure what is causing this

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 659bee9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JoviDeCroock JoviDeCroock changed the title fixies Preact >= 10.18.2 compatability Nov 11, 2023
@andrewiggins
Copy link
Member

Weird, I'm only seeing the lazy test fail locally. Looking into that

andrewiggins
andrewiggins reviewed Nov 13, 2023
View reviewed changes
packages/core/src/index.js
Comment on lines +101 to +103
vnode.type = NewType
vnode[VNODE_COMPONENT].__v = vnode;
vnode[VNODE_COMPONENT].__v.type = NewType;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think line 101 & 103 can be removed since they are redundant of each other and line 59.

packages/core/src/runtime/vnode.js
Comment on lines -33 to +39
vnode.type = foundType;
// vnode.type = foundType;
if (
vnode[VNODE_COMPONENT] &&
'prototype' in vnode.type &&
vnode.type.prototype.render
) {
vnode[VNODE_COMPONENT].constructor = vnode.type;
vnode[VNODE_COMPONENT].constructor = foundType;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found undoing this change to fix the failing suspense test

@andrewiggins andrewiggins mentioned this pull request Nov 13, 2023
Merged
@JoviDeCroock JoviDeCroock deleted the trying-fixes branch November 13, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewiggins andrewiggins andrewiggins left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoviDeCroock @andrewiggins