Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preact >= 10.18.2 compatability #528

Closed
wants to merge 14 commits into from
Closed

Preact >= 10.18.2 compatability #528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0946f88
fixies
JoviDeCroock Nov 11, 2023
5d5fa8f
temp pin version
JoviDeCroock Nov 11, 2023
f2c0f5e
add back vnode cast
JoviDeCroock Nov 11, 2023
d4120bd
revert
JoviDeCroock Nov 11, 2023
b3781f2
10.19.1
JoviDeCroock Nov 11, 2023
15e06b2
correct starting values
JoviDeCroock Nov 11, 2023
87c7bb5
more tries
JoviDeCroock Nov 11, 2023
6eea998
more tries
JoviDeCroock Nov 11, 2023
e6a3d0c
try removing mapping logic
JoviDeCroock Nov 11, 2023
61ff615
revert
JoviDeCroock Nov 11, 2023
01fd0c0
try once more
JoviDeCroock Nov 11, 2023
2a2bff0
try with 10.18.2 to see whether the context bug is related to the new…
JoviDeCroock Nov 11, 2023
827b4ac
try with 10.18.1
JoviDeCroock Nov 11, 2023
659bee9
revert
JoviDeCroock Nov 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/core/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,10 @@ function replaceComponent(OldType, NewType, resetHookState) {
vnode[VNODE_COMPONENT].constructor = NewType;
}

vnode.type = NewType
vnode[VNODE_COMPONENT].__v = vnode;
vnode[VNODE_COMPONENT].__v.type = NewType;
Comment on lines +101 to +103
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think line 101 & 103 can be removed since they are redundant of each other and line 59.


if (resetHookState) {
if (
vnode[VNODE_COMPONENT][COMPONENT_HOOKS] &&
Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/runtime/vnode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,13 @@ options.vnode = vnode => {
}
}

vnode.type = foundType;
// vnode.type = foundType;
if (
vnode[VNODE_COMPONENT] &&
'prototype' in vnode.type &&
vnode.type.prototype.render
) {
vnode[VNODE_COMPONENT].constructor = vnode.type;
vnode[VNODE_COMPONENT].constructor = foundType;
Comment on lines -33 to +39
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found undoing this change to fix the failing suspense test

}
}

Expand Down
2 changes: 1 addition & 1 deletion test/fixture/vite-preact-compat/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
},
"dependencies": {
"goober": "^2.0.36",
"preact": "^10.19.0"
"preact": "10.19.1"
},
"devDependencies": {
"@babel/core": "^7.22.1",
Expand Down
2 changes: 1 addition & 1 deletion test/fixture/vite-signals/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
},
"dependencies": {
"@preact/signals": "^1.1.2",
"preact": "^10.19.0"
"preact": "10.19.1"
},
"devDependencies": {
"@babel/core": "^7.22.1",
Expand Down
2 changes: 1 addition & 1 deletion test/fixture/vite/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
},
"dependencies": {
"goober": "^2.0.36",
"preact": "^10.19.0"
"preact": "10.18.1"
},
"devDependencies": {
"@babel/core": "^7.22.1",
Expand Down
Loading