Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various bidders: bypass of storage manager rules violation #8689

Closed
patmmccann opened this issue Jul 14, 2022 · 0 comments · Fixed by #8690
Closed

Various bidders: bypass of storage manager rules violation #8689

patmmccann opened this issue Jul 14, 2022 · 0 comments · Fixed by #8690
Assignees
@patmmccann
Labels
bug

Comments

@patmmccann
Copy link
Collaborator

patmmccann commented Jul 14, 2022 •
edited
Loading

The following modules should have these bypasses fixed or disabled:

Modules should import storageManager and use for example, storage.getDataFromLocalStorage. In this way, deviceAccess controls and gdpr enforcement modules will govern the access

Prebid.js/modules/kargoBidAdapter.js

Line 128 in 846bc8d

let cookies = document.cookie.split(';');

@jsadwith

Prebid.js/modules/widespaceBidAdapter.js

Line 200 in 3fd3b5d

document.cookie.split(';').forEach((item) => {

Prebid.js/modules/widespaceBidAdapter.js

Line 189 in 3fd3b5d

Object.keys(localStorage).filter((key) => {

@talha08

Prebid.js/modules/fintezaAnalyticsAdapter.js

Line 41 in e47b908

cookies = parseCookies(document.cookie);

@finteza

Prebid.js/modules/sspBCBidAdapter.js

Line 104 in 6f4fb5b

const useCookies = navigator.cookieEnabled || !!document.cookie.length;

@wojciech-bialy-wpm

Prebid.js/modules/insticatorBidAdapter.js

Line 42 in 06e2976

localStorage.setItem(USER_ID_KEY, userId);

@EugeneVigonny

Prebid.js/modules/pubwiseAnalyticsAdapter.js

Line 160 in 6f4fb5b

return storage.getDataFromLocalStorage(localStorageSessName()) ? localStorage.getItem(localStorageSessName()) : '';

@GLStephen

https://github.com/prebid/Prebid.js/blame/5534049666913829624589561cdcb51e9038a8c7/modules/invibesBidAdapter.js#L384

@invibes
@patmmccann patmmccann moved this from Triage to Ready for Dev in Prebid.js Tactical Issues table Jul 14, 2022
@patmmccann patmmccann added the bug label Jul 14, 2022
@patmmccann patmmccann moved this from Ready for Dev to In progress in Prebid.js Tactical Issues table Jul 14, 2022
@patmmccann patmmccann self-assigned this Jul 14, 2022
@patmmccann patmmccann mentioned this issue Jul 14, 2022
Merged
thomasdseao added a commit to Impactify-AdTech/Prebid.js that referenced this issue Jul 15, 2022
@thomasdseao
Remove use of local storage
3c2be25 
As requested, we remove the use of local storage.
prebid#8689
@thomasdseao thomasdseao mentioned this issue Jul 15, 2022
Merged
patmmccann pushed a commit that referenced this issue Jul 15, 2022
@thomasdseao
Impactify Bid Adapter: Remove use of local storage debugging flag (#8693
d73091c 
)

* Remove use of local storage

As requested, we remove the use of local storage.
#8689

* Update impactifyBidAdapter.js
@jvnnc jvnnc mentioned this issue Jul 18, 2022
Merged
1 task
@patmmccann patmmccann moved this from In progress to PR submitted in Prebid.js Tactical Issues table Jul 18, 2022
Repository owner moved this from PR submitted to Done in Prebid.js Tactical Issues table Jul 22, 2022
ahmadlob pushed a commit to taboola/Prebid.js that referenced this issue Jul 27, 2022
@thomasdseao @ahmadlob
Impactify Bid Adapter: Remove use of local storage debugging flag (#8…
3e9dc7e 
…693)

* Remove use of local storage

As requested, we remove the use of local storage.
prebid/Prebid.js#8689

* Update impactifyBidAdapter.js
ccorbo pushed a commit to ccorbo/Prebid.js that referenced this issue Jul 27, 2022
@thomasdseao
Impactify Bid Adapter: Remove use of local storage debugging flag (pr…
1de22ea 
…ebid#8693)

* Remove use of local storage

As requested, we remove the use of local storage.
prebid#8689

* Update impactifyBidAdapter.js
@wojciech-bialy-wpm wojciech-bialy-wpm mentioned this issue Aug 1, 2022
Merged
1 task
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this issue May 23, 2023
@thomasdseao @jorgeluisrocha
Impactify Bid Adapter: Remove use of local storage debugging flag (pr…
53fee60 
…ebid#8693)

* Remove use of local storage

As requested, we remove the use of local storage.
prebid#8689

* Update impactifyBidAdapter.js
Fawke pushed a commit that referenced this issue Oct 30, 2023
@thomasdseao @timpactifyo91
Impactify Bid Adapter : add different mediatypes and manage local sto…
5bea607 
…rage (#10601)

* Remove use of local storage

As requested, we remove the use of local storage.
#8689

* Update impactifyBidAdapter.js

* Add differents mediatypes to Impactify bidder

* Add differents mediatypes to Impactify bidder

* Add differents mediatypes to Impactify bidder

* Add format parameter for banner

* add getFloor

* add getFloor

* add getFloor

* add parsing of local storage

* delete unused var

* fix spacing with import

* Add local storage key management

* Adjustments

* Fix eids object

* Fix eids object

* Fix eids object

* Fix tests

---------

Co-authored-by: Thomas De Stefano <[email protected]>
Co-authored-by: Pang Ronnie <[email protected]>
ChrisHuie pushed a commit that referenced this issue Nov 28, 2023
@thomasdseao @timpactifyo91
Impactify Bid Adapter : Removing checks on bid request (#10769)
1e33758 
* Remove use of local storage

As requested, we remove the use of local storage.
#8689

* Update impactifyBidAdapter.js

* Add differents mediatypes to Impactify bidder

* Add differents mediatypes to Impactify bidder

* Add differents mediatypes to Impactify bidder

* Add format parameter for banner

* add getFloor

* add getFloor

* add getFloor

* add parsing of local storage

* delete unused var

* fix spacing with import

* Add local storage key management

* Adjustments

* Fix eids object

* Fix eids object

* Fix eids object

* Fix tests

* Remove check on the request banner size parameter

* Few adjustments

---------

Co-authored-by: Thomas De Stefano <[email protected]>
Co-authored-by: Pang Ronnie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patmmccann patmmccann

Labels
bug
Projects
Prebid.js Tactical Issues table
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Various adapters: remove use of storageManager bypasses prebid/Prebid.js
1 participant
@patmmccann