Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impactify Bid Adapter : add different mediatypes and manage local storage #10601

Merged
merged 23 commits into from
Oct 30, 2023

Conversation

thomasdseao
Copy link
Contributor

@thomasdseao thomasdseao commented Oct 12, 2023

Type of change

  • Feature
  • Code style update (formatting, local variables)

Description of change

Handling the parsing of a local storage value denoted by the key "_im_str" and managing more mediatypes.

@thomasdseao
Copy link
Contributor Author

Linked doc PR : prebid/prebid.github.io#4926

@thomasdseao thomasdseao changed the title Impactify : Add different mediatypes + Manage one local storage key #2 Impactify Bid Adapter : Add different mediatypes + Manage one local storage key #2 Oct 12, 2023
@ChrisHuie ChrisHuie requested a review from Fawke October 17, 2023 10:19
@ChrisHuie ChrisHuie changed the title Impactify Bid Adapter : Add different mediatypes + Manage one local storage key #2 Impactify Bid Adapter : add different mediatypes and manage local storage Oct 17, 2023
Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @thomasdseao,

gulp test command fails. Can you please fix this?
A potential reason for this failure, I don't think you can import function createEidsArray.

If you wanna read eids, you can read it off of bidRequest object.

function getEids(bidRequest) {
  if (deepAccess(bidRequest, 'userIdAsEids')) {
    return bidRequest.userIdAsEids || [];
  }
};

@thomasdseao
Copy link
Contributor Author

Hi @thomasdseao,

gulp test command fails. Can you please fix this? A potential reason for this failure, I don't think you can import function createEidsArray.

If you wanna read eids, you can read it off of bidRequest object.

function getEids(bidRequest) {
  if (deepAccess(bidRequest, 'userIdAsEids')) {
    return bidRequest.userIdAsEids || [];
  }
};

Hi @Fawke ,
Fixed.

@Fawke
Copy link
Contributor

Fawke commented Oct 26, 2023

@thomasdseao I still see unit tests are failing. Can you please run gulp test and fix the test case? I see one error originating from your test case.

@thomasdseao
Copy link
Contributor Author

@Fawke Is should be fixed now. Thank you.

Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fawke Fawke merged commit 5bea607 into prebid:master Oct 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants