-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impactify Bid Adapter : add different mediatypes and manage local storage #10601
Conversation
As requested, we remove the use of local storage. prebid#8689
Impactify Bid Adapter: add handling of localstorage
Impactify : Add different mediatypes + Manage one local storage key
Linked doc PR : prebid/prebid.github.io#4926 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @thomasdseao,
gulp test
command fails. Can you please fix this?
A potential reason for this failure, I don't think you can import function createEidsArray
.
If you wanna read eids, you can read it off of bidRequest object.
function getEids(bidRequest) {
if (deepAccess(bidRequest, 'userIdAsEids')) {
return bidRequest.userIdAsEids || [];
}
};
Hi @Fawke , |
@thomasdseao I still see unit tests are failing. Can you please run |
@Fawke Is should be fixed now. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Type of change
Description of change
Handling the parsing of a local storage value denoted by the key "_im_str" and managing more mediatypes.