Yieldmo bid adapter #1415

xlozinguez · 2017-07-25T18:04:55Z

Type of change

Description of change

Added Yieldmo adapter

test parameters for validating bids

{
  bidder: 'yieldmo',
  params: {}
}

Be sure to test the integration with your adserver using the Hello World sample page.

contact email of the adapter’s maintainer: [email protected]
official adapter submission

Other information

@cdoher01 @harquail @yieldmo-rao @elberdev

Feature/yieldmo bid adapter

cdoher01 · 2017-07-25T19:42:48Z

Please note it's a new adapter, not a feature, misclicked :/ (I can't change it for some reason it says "You can't perform that action at this time.")

harquail · 2017-07-25T19:48:42Z

modules/yieldmoBidAdapter.js

+    var e = 4; // 0 (COP) or 4 (DFP) for now -- ad server should reject other environments (TODO: validate that it will always be the case)
+    var bust = new Date().getTime().toString(); // cache buster
+    var scrd = window.devicePixelRatio || 0; // screen pixel density
+    var ae = 0; // prebid adapter version


I don't think we need to send this (per Rahul Jain)

also misleading comment 😸

elberdev · 2017-07-25T20:57:47Z

modules/yieldmoBidAdapter.js

+    }
+
+    // @if NODE_ENV='debug'
+    // utils.logMessage('ymCall request built: ' + ymCall);


Should this be commented out?

dbemiller · 2017-08-01T19:01:33Z

Hey. This code looks good... but I'm not getting any bids during test. These are my ad units (plugged into integrationExamples/gpt/hello_world.html):

var adUnits = [{
        code: 'div-gpt-ad-1460505748561-0',
        sizes: [[300, 250], [300,600]],

        // Replace this object to test a new Adapter!
        bids: [{
          bidder: 'yieldmo',
          params: {}
        }]

      }];

This also turned up a bug. Your server is returning {} for me, which your YMCB handler processes by doing nothing. Prebid then waits for your bid until the auction's timeout, which is really bad for the publisher's page's performance.

You need to make sure your adapter calls addBidResponse with a NO_BID bid regardless of what your server returns. Please add some unit tests to make sure this happens.

^^ This code flow never triggers a call to addBidResponse

Update bid adapter with fallback for incorrect bid response

cdoher01 · 2017-08-23T16:51:28Z

Hey @dbemiller I've updated the bid adapter to add NOBID responses if the server returns an invalid response. We've also got our endpoint up now so you should see a valid response if you try it again. Thanks!

cdoher01 · 2017-08-30T21:19:43Z

@dbemiller Hey just wanted to check if there is anything else we need to do to keep this moving forward. Thanks!

dbemiller

Sorry for the long lagtime. Been dealing with production stuff and neglecting JS.

This is almost mergeable... the only change which really needs to happen is the Object.assign. The rest is just FYI, because we're expecting to start pushing adapters to become 1.0-compliant in the next few weeks.

I did verify that the auction is ending properly when the server responds with a {} now.

I'm still not able to get a true bid back from the server, though. Maybe the test campaign has ended? I'm running this from the US, if it matters.

dbemiller · 2017-08-31T14:13:11Z

modules/yieldmoBidAdapter.js

+
+  return {
+    callBids: _callBids
+  };


Needs to be:

return Object.assign(this, { callBids: _callBids });

See #1459

dbemiller · 2017-08-31T14:19:03Z

modules/yieldmoBidAdapter.js

+  }
+
+  // expose the callback to the global object:
+  $$PREBID_GLOBAL$$.YMCB = function(ymResponses) {


This is fine for right now... but beware that Prebid will be dropping support for JSONP in version 1.0, which should be coming in the next few months.

Okay, I'll make a note for us to update this. Do you know if any existing adapters are a good example to look at for 1.0 compatible callback?

We won't be letting servers respond with code in 1.0--just data. So you'll be making a GET/POST request, and then unpacking bids from the JSON (or XML, plain text, etc) in the response body.

The exact API for adapters in 1.0 is still under discussion in #1494, if you want to take a look and make suggestions over there. I'm updating the appnexusAst adapter to help prototype it.

dbemiller · 2017-08-31T14:24:03Z

modules/yieldmoBidAdapter.js

+  }
+
+  function _registerNoResponseBids() {
+    var yieldmoBidRequests = $$PREBID_GLOBAL$$._bidsRequested.find(bid => bid.bidderCode === 'yieldmo');


Same issue here... this is fine for now, but won't work in Prebid 1.0. #1421 breaks it, since different auctions will have different bid requests, so the global _bidsRequested array won't be valid anymore.

dbemiller · 2017-08-31T14:28:41Z

modules/yieldmoBidAdapter.js

+      bidmanager.addBidResponse(placementCode, bid);
+    } else {
+      // no response data
+      // @if NODE_ENV='debug'


Prebid isn't using preprocess... so it won't respect these annotations.

The utils.logMessage function is a no-op unless debugging is enabled, though.

Feature/update return object

cdoher01 · 2017-08-31T18:09:59Z

@dbemiller Thanks for taking another look. I've updated to use Object.assign. Looks like the ad response is still up, you could reference this test page to see an example of the response coming back: http://s3.amazonaws.com/static.yieldmo.com/icons/beta/hello_world.html

Let me know if there is anything else to update to get this first version in. Thanks! Connor

cdoher01 · 2017-08-31T18:12:46Z

Oh, one thing to note is that we only run our ads on mobile so you will want to put the browser into mobile emulation to get back a full bid response, that might be why you weren't seeing a full response.

dbemiller

Aha... that explains it. Bid came back when I emulated mobile.

Ok, this looks good. I left behind two more little cleanup comments... but they're not blockers by any means.

dbemiller · 2017-09-01T17:52:08Z

modules/yieldmoBidAdapter.js

+      // to prevent Prebid waiting till timeout for response 
+      _registerNoResponseBids();
+
+      // @if NODE_ENV='debug'


Can also be removed

dbemiller · 2017-09-01T17:52:21Z

modules/yieldmoBidAdapter.js

+      ymCall = ymCall.substring(0, ymCall.length - 1);
+    }
+
+    // @if NODE_ENV='debug'


Can also be removed

Remove unneeded comments

cdoher01 · 2017-09-05T14:35:54Z

Cool thanks, @dbemiller I've removed those other unneeded comments. @jaiminpanchal27 let me know if you spot anything else that needs updating before it ready to go. Thanks!

cdoher01 · 2017-09-08T17:25:15Z

@jaiminpanchal27 @dbemiller Thanks for reviewing and getting this merged in! Is there a place that I need to make a PR to have Yieldmo show up on the list of Bid Adapters here: http://prebid.org/download.html ? Thanks

dbemiller · 2017-09-08T17:25:57Z

@cdoher01 yes. Make a PR against the docs repo: https://github.com/prebid/prebid.github.io

cdoher01 · 2017-09-08T17:59:00Z

@dbemiller cool will do, thanks!

mkendall07 · 2017-09-08T18:00:09Z

@cdoher01
we'll actually take care of the http://prebid.org/download.html page automatically when we update.

dbemiller · 2017-09-08T18:02:41Z

akh... I'm sorry. For some reason I read your question as "how do I make it show up in the docs?" On this page

Listen to @mkendall07 ^^

cdoher01 · 2017-09-08T18:13:56Z

Okay cool. @mkendall07 do you roughly when the update will happen?

…built * 'master' of https://github.com/prebid/Prebid.js: (46 commits) Serverbid alias (prebid#1560) Add user sync to process for approving adapter PRs (prebid#1457) fix travis build (prebid#1595) Rubicon project improvement/user sync (prebid#1549) Adding Orbitsoft adapter (prebid#1378) Fix renderer test for new validation rule (prebid#1592) Allow SET_TARGETING to be used in AnalyticsAdapter (prebid#1577) Add support for video stream context (prebid#1483) Invalidate bid if matching bid request not found (prebid#1575) allow adapters to set default adserverTargeting for specific bid (prebid#1568) Custom granularity precision should honor 0 if it is passed in closes prebid#1479 (prebid#1591) BaseAdapter for the Prebid 0.x -> 1.x transition (prebid#1494) Add a version to the Criteo adapter (prebid#1573) Allow bundling from node.js or with new gulp task bundle-to-stdout (prebid#1570) Add url.parse option to not decode the whole URL (prebid#1480) Tremor Video Bid Adapter (prebid#1552) Yieldmo bid adapter (prebid#1415) Switch `gulp docs` to build its output using documentation.js (prebid#1545) Increment pre version Prebid 0.28.0 Release ...

* Create yieldmoBidAdapter file * Copy over TL adapter and change name spacing * Update bid adapter naming to Yieldmo * Init tests for yieldmoBidAdapter * Add yeildmo config to pbjs_example_gpt * feature/yieldmoBidAdapter: added request build * Update ym response to have placement and impression level info * Remove environment param * Update ym tests for single bid request structure * Update url to use _ instead of camelcase * Update YMCB to handle multiple placements in one response * Clean up and remove TODO from adapter * Update response tests to work with single response structure * Remove trailing space * Cleanup * Adjusted code according to CR comments * Update bid adapter with fallback for incorrect bid response * Update yeildmo prebid endpoint * Add check to make sure response is an Array * Remove environment tracking as we are no going to use this * Update test to pass with new Yieldmo endpoint * Update return obj and remove node debug comments * Remove changes to hello_world and yarn.lock files * Remove unneeded comments

cdoher01 · 2017-10-05T18:57:05Z

@mkendall07 just following up, do you know the timeline for updating the download page? Would be nice to have Yieldmo bid adapter available to download via option 1. Thanks

* Create yieldmoBidAdapter file * Copy over TL adapter and change name spacing * Update bid adapter naming to Yieldmo * Init tests for yieldmoBidAdapter * Add yeildmo config to pbjs_example_gpt * feature/yieldmoBidAdapter: added request build * Update ym response to have placement and impression level info * Remove environment param * Update ym tests for single bid request structure * Update url to use _ instead of camelcase * Update YMCB to handle multiple placements in one response * Clean up and remove TODO from adapter * Update response tests to work with single response structure * Remove trailing space * Cleanup * Adjusted code according to CR comments * Update bid adapter with fallback for incorrect bid response * Update yeildmo prebid endpoint * Add check to make sure response is an Array * Remove environment tracking as we are no going to use this * Update test to pass with new Yieldmo endpoint * Update return obj and remove node debug comments * Remove changes to hello_world and yarn.lock files * Remove unneeded comments

Connor Doherty and others added 16 commits July 17, 2017 11:09

Create yieldmoBidAdapter file

11b6a54

Copy over TL adapter and change name spacing

4e782b0

Update bid adapter naming to Yieldmo

5e1a577

Init tests for yieldmoBidAdapter

28d584d

Add yeildmo config to pbjs_example_gpt

5a31918

feature/yieldmoBidAdapter: added request build

4068db6

Update ym response to have placement and impression level info

420910f

Remove environment param

5428371

Update ym tests for single bid request structure

0419c0f

Update url to use _ instead of camelcase

22768d2

Update YMCB to handle multiple placements in one response

50e9087

Clean up and remove TODO from adapter

2838948

Update response tests to work with single response structure

8c1b0d6

Remove trailing space

53063a7

Cleanup

308cbe1

Merge pull request #1 from yieldmo/feature/yieldmoBidAdapter

8cfc236

Feature/yieldmo bid adapter

harquail reviewed Jul 25, 2017

View reviewed changes

elberdev reviewed Jul 25, 2017

View reviewed changes

Adjusted code according to CR comments

2bf6d29

dbemiller self-assigned this Jul 31, 2017

dbemiller added the needs update label Aug 1, 2017

Connor Doherty and others added 4 commits August 9, 2017 11:35

Update bid adapter with fallback for incorrect bid response

525f1a9

Update yeildmo prebid endpoint

517536b

Add check to make sure response is an Array

39bfc99

Merge pull request #2 from yieldmo/feature/handle_bid_response_errors

2776712

Update bid adapter with fallback for incorrect bid response

Connor Doherty added 2 commits August 23, 2017 12:56

Remove environment tracking as we are no going to use this

59ce30b

Merge branch 'master' of https://github.com/yieldmo/Prebid.js

37124fc

Update test to pass with new Yieldmo endpoint

fce2a4c

dbemiller suggested changes Aug 31, 2017

View reviewed changes

Connor Doherty and others added 3 commits August 31, 2017 13:47

Update return obj and remove node debug comments

5c7d3a7

Remove changes to hello_world and yarn.lock files

98b1589

Merge pull request #3 from yieldmo/feature/update_return_object

a5f8ed1

Feature/update return object

dbemiller approved these changes Sep 1, 2017

View reviewed changes

dbemiller assigned jaiminpanchal27 Sep 1, 2017

dbemiller requested a review from jaiminpanchal27 September 1, 2017 17:54

dbemiller removed their assignment Sep 1, 2017

dbemiller added LGTM needs review and removed needs update labels Sep 1, 2017

Connor Doherty and others added 2 commits September 5, 2017 10:32

Remove unneeded comments

06bda89

Merge pull request #4 from yieldmo/feature/cleanup

b5b9d1f

Remove unneeded comments

jaiminpanchal27 approved these changes Sep 8, 2017

View reviewed changes

jaiminpanchal27 merged commit 598817f into prebid:master Sep 8, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Yieldmo bid adapter #1415

Yieldmo bid adapter #1415

xlozinguez commented Jul 25, 2017 •

edited

Loading

cdoher01 commented Jul 25, 2017

harquail Jul 25, 2017

harquail Jul 25, 2017

elberdev Jul 25, 2017

dbemiller commented Aug 1, 2017 •

edited

Loading

cdoher01 commented Aug 23, 2017

cdoher01 commented Aug 30, 2017

dbemiller left a comment

dbemiller Aug 31, 2017

cdoher01 Aug 31, 2017

dbemiller Aug 31, 2017

cdoher01 Aug 31, 2017

dbemiller Sep 1, 2017

dbemiller Aug 31, 2017

dbemiller Aug 31, 2017

cdoher01 Aug 31, 2017

cdoher01 commented Aug 31, 2017

cdoher01 commented Aug 31, 2017

dbemiller left a comment

dbemiller Sep 1, 2017

dbemiller Sep 1, 2017

cdoher01 commented Sep 5, 2017

cdoher01 commented Sep 8, 2017

dbemiller commented Sep 8, 2017

cdoher01 commented Sep 8, 2017

mkendall07 commented Sep 8, 2017

dbemiller commented Sep 8, 2017

cdoher01 commented Sep 8, 2017

cdoher01 commented Oct 5, 2017

Yieldmo bid adapter #1415

Yieldmo bid adapter #1415

Conversation

xlozinguez commented Jul 25, 2017 • edited Loading

Type of change

Description of change

Other information

cdoher01 commented Jul 25, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dbemiller commented Aug 1, 2017 • edited Loading

cdoher01 commented Aug 23, 2017

cdoher01 commented Aug 30, 2017

dbemiller left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cdoher01 commented Aug 31, 2017

cdoher01 commented Aug 31, 2017

dbemiller left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cdoher01 commented Sep 5, 2017

cdoher01 commented Sep 8, 2017

dbemiller commented Sep 8, 2017

cdoher01 commented Sep 8, 2017

mkendall07 commented Sep 8, 2017

dbemiller commented Sep 8, 2017

cdoher01 commented Sep 8, 2017

cdoher01 commented Oct 5, 2017

xlozinguez commented Jul 25, 2017 •

edited

Loading

dbemiller commented Aug 1, 2017 •

edited

Loading