Tremor Video Bid Adapter #1552
Merged
Tremor Video Bid Adapter #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with what we use at tremor. - Changed a test to look for document.location.href instead of a hardcoded localhost url.
matthewlane
reviewed
Sep 6, 2017
modules/tremorBidAdapter.js
Outdated
| bid.crid = response.crid; | ||
| bid.vastXml = response.adm; | ||
| // This is a dummy vast URL, Tremor sends back the vast XML (the line above). | ||
| bid.vastUrl = 'http://cdn.tremorhub.com/static/dummy.xml'; |
There was a problem hiding this comment.
Bid responses with a vastXml property will now pass validation with #1556 in master, so if Tremor sends xml and not a vast url, this line can be dropped
matthewlane
approved these changes
Sep 7, 2017
dbemiller
reviewed
Sep 7, 2017
| @@ -1945,7 +1945,7 @@ d@1: | |||
| dependencies: | |||
| es5-ext "^0.10.9" | |||
|
|
|||
| "dargs@github:christian-bromann/dargs": | |||
| dargs@christian-bromann/dargs: | |||
There was a problem hiding this comment.
This doesn't look intentional... not sure why it changed?
There was a problem hiding this comment.
Running yarn install on current master resulted in this update to the lockfile for me too. I tried deleting node_modules then yarn install again with this changed lockfile and things still build out properly
There was a problem hiding this comment.
ahh... common mistake. I ran into this recently, and it's just a weird API on their part.
yarn install pulls the latest dependencies which package.json allows. This might change your yarn.lock, if someone released a new version of a package recently.
yarn install --pure-lockfile installs the dependencies from yarn.lock without changing them.
Very unlikely to do any real harm, though.
outoftime
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Sep 18, 2017
…built * 'master' of https://github.com/prebid/Prebid.js: (46 commits) Serverbid alias (prebid#1560) Add user sync to process for approving adapter PRs (prebid#1457) fix travis build (prebid#1595) Rubicon project improvement/user sync (prebid#1549) Adding Orbitsoft adapter (prebid#1378) Fix renderer test for new validation rule (prebid#1592) Allow SET_TARGETING to be used in AnalyticsAdapter (prebid#1577) Add support for video stream context (prebid#1483) Invalidate bid if matching bid request not found (prebid#1575) allow adapters to set default adserverTargeting for specific bid (prebid#1568) Custom granularity precision should honor 0 if it is passed in closes prebid#1479 (prebid#1591) BaseAdapter for the Prebid 0.x -> 1.x transition (prebid#1494) Add a version to the Criteo adapter (prebid#1573) Allow bundling from node.js or with new gulp task bundle-to-stdout (prebid#1570) Add url.parse option to not decode the whole URL (prebid#1480) Tremor Video Bid Adapter (prebid#1552) Yieldmo bid adapter (prebid#1415) Switch `gulp docs` to build its output using documentation.js (prebid#1545) Increment pre version Prebid 0.28.0 Release ...
jbAdyoulike
pushed a commit
to jbAdyoulike/Prebid.js
that referenced
this pull request
Sep 21, 2017
* Added tremor bid adapter for prebid.js * - Fixed some tests. * - Added some comments and changed a few variable names to be in line with what we use at tremor. - Changed a test to look for document.location.href instead of a hardcoded localhost url. * - Some formatting. * - Removed the vastUrl field from the adapter.
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* Added tremor bid adapter for prebid.js * - Fixed some tests. * - Added some comments and changed a few variable names to be in line with what we use at tremor. - Changed a test to look for document.location.href instead of a hardcoded localhost url. * - Some formatting. * - Removed the vastUrl field from the adapter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Tremor video bid adapter.
Other information