add adomain to bid.meta in spotx adapter #5401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please check @npeceniak ; thanks! |
|
Assigned to @FilipStamenkovic Please add a unit test @patmmccann |
FilipStamenkovic
approved these changes
Jun 23, 2020
There was a problem hiding this comment.
LGTM, can you just add unit test for the changes, like @robertrmartinez already mentioned.
FilipStamenkovic
suggested changes
Jun 23, 2020
|
Hopefully this last one solves the problem :)
…On Tue, Jun 23, 2020 at 9:46 AM Filip Stamenkovic ***@***.***> wrote:
***@***.**** requested changes on this pull request.
After this commit I see failure on circleci.
I run tests locally and I also see that they are failing on my local. Can
you take a look?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5401 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM25ZYSLHR6UYOCP2UBUMLRYCW27ANCNFSM4OC3PWJQ>
.
|
FilipStamenkovic
approved these changes
Jun 23, 2020
jsnellbaker
added a commit
that referenced
this pull request
Jul 23, 2020
* remove these adapters from 4.0 (#5369) Co-authored-by: sumit sharma <[email protected]> * add meta key to interpreted bid response (#5358) * add meta key to interpreted bid response * add more unit tests Co-authored-by: sumit sharma <[email protected]> Co-authored-by: sumit sharma <[email protected]> * add adomain to bid.meta in spotx adapter (#5401) * add adomain to bid.meta in spotx adapter this puts the adomain key in the right spot, related to #5358 and partially solves #3115 for SpotX * Update spotxBidAdapter.js * Update spotxBidAdapter.js * unit test for adomain on spotx adapter * Update spotxBidAdapter_spec.js * Update spotxBidAdapter_spec.js * adds advertiserDomains meta to the pubmatic adapter (#5402) * adds advertiserDomains meta * Update pubmaticBidAdapter.js * unit test for meta.advertiserDomains to pubmatic * Update pubmaticBidAdapter_spec.js * TCF Purpose 1 and Purpose 2 enforcement for Prebid v4.0 (#5336) * TCF v2.0 enforcement * test/spec/modules/gdprEnforcement_spec.js * add check for gdpr version * add logInfo message * remove comment and store value of PURPOSES in an object * add gvlid check * add unit tests for validateRules function * remove purposeId parameter from validateRules function * add extra tests * make failing unit test case pass * deprecate allowAuctionWithouConsent with tcf 2 workflow * add extra checks for defaults * remove tcf 2 test page * add strict gvlid check * add comments and shorten log messages * shorted log messages * add unit tests for setEnforcementConfig * add gvlid for alias and gvlMapping support * remove gvlid check * add support to add gvlid for aliases Co-authored-by: Jaimin Panchal <[email protected]> * add advertiserDomains meta field to ix adapter (#5404) * add advertiserDomains meta field to ix adapter * Update ixBidAdapter.js * Update ixBidAdapter_spec.js * Update ixBidAdapter_spec.js * add adomain to bid.meta in telaria adapter (#5400) * add adomain to bid.meta in telaria adapter this puts the adomain key in the right spot, related to #5358 and partially solves #3115 for Telaria * Remove digitrust from prebid server js adapter (#5438) * Update prebidServerBidAdapter_spec.js * Update index.js * Interactive advertising bureau digitrust exit (#5429) * Removing DigiTrust ID system core. * Removing test spec for digitrust id. * Removing DigiTrust references from eids test spec. Co-authored-by: Chris Cole <[email protected]> * Delete serverbidBidAdapter.md (#5477) deprecated in favor of consumable adapter * Set cookie domain in pubcid / userid on main domain, not subdomain (#5500) * update formatting * update formatting * requested changes implemented * add unit test * add test case for missing adomain in ix adapter (#5422) * add test case for missing adomain in ix adapter at request of @ix-prebid-support on #5404 * Update ixBidAdapter_spec.js * Update ixBidAdapter_spec.js * Update ixBidAdapter_spec.js * drop support for userId configs with the `usersync` config object (#5427) * drop support for userId configs with the `usersync` config object, per deprecation notice * changes on drop support (#1) * Update userIdTargeting.md * Update userId.md * Update userId_spec.js * Update britepoolIdSystem.md * Update sharedIdSystem.md Co-authored-by: Patrick McCann <[email protected]> Co-authored-by: sumit sharma <[email protected]> Co-authored-by: sumit sharma <[email protected]> Co-authored-by: sumit sharma <[email protected]> Co-authored-by: Patrick McCann <[email protected]> Co-authored-by: Neelanjan Sen <[email protected]> Co-authored-by: Jaimin Panchal <[email protected]> Co-authored-by: Neelanjan Sen <[email protected]> Co-authored-by: Chris Cole <[email protected]> Co-authored-by: Isaac A. Dettman <[email protected]> Co-authored-by: Scott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
this puts the adomain key in the right spot, related to #5358 and partially solves #3115 for SpotX