Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop support for userId configs with the usersync config object, pe… #5427

Merged
merged 5 commits into from
Jul 21, 2020
Merged

drop support for userId configs with the usersync config object, pe… #5427

merged 5 commits into from
Jul 21, 2020

Conversation

smenzer
Copy link
Collaborator

@smenzer smenzer commented Jun 26, 2020

Type of change

  • [ X ] Bugfix
  • [ ? ] Does this change affect user-facing APIs or examples documented on http://prebid.org?

Description of change

Per comments, and likely an early-on oversight, we were allowing two different userSync configurations to be made (based on case of the word usersync), although only one was supported at a time. This PR drops support for usersync and will require publishers to all use userSync when setting configurations for userId module.

I'm not sure if we need docs changes or not, but I think they already specify to use userSync

Other information

See comment in current code specifying we will make this change: https://github.com/prebid/Prebid.js/blob/master/modules/userId/index.js#L573

@smenzer smenzer requested a review from idettman June 26, 2020 22:34
patmmccann
patmmccann approved these changes Jul 17, 2020
View reviewed changes
modules/userId/index.js Show resolved Hide resolved
patmmccann
patmmccann requested changes Jul 17, 2020
View reviewed changes
modules/userId/index.js Show resolved Hide resolved
patmmccann
patmmccann requested changes Jul 17, 2020
View reviewed changes
modules/userId/index.js Show resolved Hide resolved
@patmmccann
changes on drop support (#1)
bc3eb76 
* Update userIdTargeting.md

* Update userId.md

* Update userId_spec.js
@jsnellbaker jsnellbaker self-requested a review July 20, 2020 15:02
jsnellbaker
jsnellbaker requested changes Jul 20, 2020
View reviewed changes
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smenzer
There are a couple other documentation files that use the usersync syntax. Could you update these other examples as well?

Below is what I found during my search through the repo:

  • modules/britepoolIdSystem.md
  • modules/sharedIdSystem.md

I think we should be good to merge after this last update.

@smenzer
Copy link
Collaborator Author

smenzer commented Jul 20, 2020

@smenzer
There are a couple other documentation files that use the usersync syntax. Could you update these other examples as well?

Below is what I found during my search through the repo:

  • modules/britepoolIdSystem.md
  • modules/sharedIdSystem.md

I think we should be good to merge after this last update.

Sure thing! will do that first thing tomorrow morning

@patmmccann
Copy link
Collaborator

@smenzer
There are a couple other documentation files that use the usersync syntax. Could you update these other examples as well?
Below is what I found during my search through the repo:

  • modules/britepoolIdSystem.md
  • modules/sharedIdSystem.md

I think we should be good to merge after this last update.

Sure thing! will do that first thing tomorrow morning

smenzer-forks#2 should take care of it for you

@smenzer
Merge pull request #2 from patmmccann/patch-23
5be8425 
fix sharedid and britepool example configs
@smenzer
Copy link
Collaborator Author

smenzer commented Jul 21, 2020

thanks @patmmccann for the PRs! @jsnellbaker this should be ready for you to merge in to the 4.0 branch.

@jsnellbaker jsnellbaker merged commit d99e637 into prebid:prebid-4.0 Jul 21, 2020
@jsnellbaker jsnellbaker mentioned this pull request Jul 23, 2020
Merged
1 task
jsnellbaker added a commit that referenced this pull request Jul 23, 2020
@jsnellbaker @sumit116
@patmmccann @Fawke @goosemanjack @smenzer
Prebid 4.0 updates (#5534)
61ba086 
* remove these adapters from 4.0 (#5369)

Co-authored-by: sumit sharma <[email protected]>

* add meta key to interpreted bid response (#5358)

* add meta key to interpreted bid response

* add more unit tests

Co-authored-by: sumit sharma <[email protected]>
Co-authored-by: sumit sharma <[email protected]>

* add adomain to bid.meta in spotx adapter (#5401)

* add adomain to bid.meta in spotx adapter


this puts the adomain key in the right spot, related to #5358 and partially solves #3115 for SpotX

* Update spotxBidAdapter.js

* Update spotxBidAdapter.js

* unit test for adomain on spotx adapter

* Update spotxBidAdapter_spec.js

* Update spotxBidAdapter_spec.js

* adds advertiserDomains meta to the pubmatic adapter (#5402)

* adds advertiserDomains meta

* Update pubmaticBidAdapter.js

* unit test for meta.advertiserDomains to pubmatic

* Update pubmaticBidAdapter_spec.js

* TCF Purpose 1 and Purpose 2 enforcement for Prebid v4.0 (#5336)

* TCF v2.0 enforcement

* test/spec/modules/gdprEnforcement_spec.js

* add check for gdpr version

* add logInfo message

* remove comment and store value of PURPOSES in an object

* add gvlid check

* add unit tests for validateRules function

* remove purposeId parameter from validateRules function

* add extra tests

* make failing unit test case pass

* deprecate allowAuctionWithouConsent with tcf 2 workflow

* add extra checks for defaults

* remove tcf 2 test page

* add strict gvlid check

* add comments and shorten log messages

* shorted log messages

* add unit tests for setEnforcementConfig

* add gvlid for alias and gvlMapping support

* remove gvlid check

* add support to add gvlid for aliases

Co-authored-by: Jaimin Panchal <[email protected]>

* add advertiserDomains meta field to ix adapter (#5404)

* add advertiserDomains meta field to ix adapter

* Update ixBidAdapter.js

* Update ixBidAdapter_spec.js

* Update ixBidAdapter_spec.js

* add adomain to bid.meta in telaria adapter (#5400)

* add adomain to bid.meta in telaria adapter

this puts the adomain key in the right spot, related to #5358 and partially solves #3115 for Telaria

* Remove digitrust from prebid server js adapter (#5438)

* Update prebidServerBidAdapter_spec.js

* Update index.js

* Interactive advertising bureau digitrust exit (#5429)

* Removing DigiTrust ID system core.

* Removing test spec for digitrust id.

* Removing DigiTrust references from eids test spec.

Co-authored-by: Chris Cole <[email protected]>

* Delete serverbidBidAdapter.md (#5477)

deprecated in favor of consumable adapter

* Set cookie domain in pubcid / userid on main domain, not subdomain (#5500)

* update formatting

* update formatting

* requested changes implemented

* add unit test

* add test case for missing adomain in ix adapter (#5422)

* add test case for missing adomain in ix adapter

at request of @ix-prebid-support on #5404

* Update ixBidAdapter_spec.js

* Update ixBidAdapter_spec.js

* Update ixBidAdapter_spec.js

* drop support for userId configs with the `usersync` config object (#5427)

* drop support for userId configs with the `usersync` config object, per deprecation notice

* changes on drop support (#1)

* Update userIdTargeting.md

* Update userId.md

* Update userId_spec.js

* Update britepoolIdSystem.md

* Update sharedIdSystem.md

Co-authored-by: Patrick McCann <[email protected]>

Co-authored-by: sumit sharma <[email protected]>
Co-authored-by: sumit sharma <[email protected]>
Co-authored-by: sumit sharma <[email protected]>
Co-authored-by: Patrick McCann <[email protected]>
Co-authored-by: Neelanjan Sen <[email protected]>
Co-authored-by: Jaimin Panchal <[email protected]>
Co-authored-by: Neelanjan Sen <[email protected]>
Co-authored-by: Chris Cole <[email protected]>
Co-authored-by: Isaac A. Dettman <[email protected]>
Co-authored-by: Scott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnellbaker jsnellbaker jsnellbaker approved these changes

@patmmccann patmmccann patmmccann approved these changes

@idettman idettman Awaiting requested review from idettman

Assignees

@idettman idettman

Labels
Prebid 4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smenzer @patmmccann @jsnellbaker @idettman