Gumgum Bid Adapter: changes for parameter consistency #8742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gumgum - ADTS-175 Support multiple GG params
…-support-jp-products ADJS-1165-prebid-adaptor-changes-to-support-jp-products
|
Appears to be a breaking change, why not support both |
patmmccann
requested changes
Jul 26, 2022
patmmccann
approved these changes
Jul 26, 2022
Merged
3 tasks
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
* Gumgum - ADTS-175 Support multiple GG params * ADJS-1165-prebid-adaptor-changes-to-support-jp-products * made tweaks to the skin product for the gumgumBidAdapter * added test for new product id * updated skins parameter for consistency * updated test for updated skins parameter Co-authored-by: Lisa Benmore <[email protected]> Co-authored-by: John Bauzon <[email protected]>
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
* Gumgum - ADTS-175 Support multiple GG params * ADJS-1165-prebid-adaptor-changes-to-support-jp-products * made tweaks to the skin product for the gumgumBidAdapter * added test for new product id * updated skins parameter for consistency * updated test for updated skins parameter Co-authored-by: Lisa Benmore <[email protected]> Co-authored-by: John Bauzon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Updated the parameter for consistency with our server side implementations