Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gumgum Bid Adapter: changes for parameter consistency #8742

Merged
merged 13 commits into from
Jul 26, 2022
Merged

Gumgum Bid Adapter: changes for parameter consistency #8742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9306014
Gumgum - ADTS-175 Support multiple GG params
lbenmore Jan 3, 2022
063916e
Merge pull request #1 from gumgum/ADTS-175-support-multiple-gg-params
lbenmore Jan 11, 2022
7d3768a
merged prebid master
john-bauzon-gumgum May 5, 2022
1033d26
ADJS-1165-prebid-adaptor-changes-to-support-jp-products
john-bauzon-gumgum May 13, 2022
7ba0426
made tweaks to the skin product for the gumgumBidAdapter
john-bauzon-gumgum May 31, 2022
941429e
added test for new product id
john-bauzon-gumgum May 31, 2022
b5fd2d6
Merge pull request #4 from gumgum/ADJS-1165-prebid-adaptor-changes-to…
john-ivan Jun 9, 2022
652fdc6
Merge branch 'prebid:master' into master
john-ivan Jun 9, 2022
f14ce6f
Merge branch 'prebid:master' into master
john-ivan Jun 10, 2022
48de4d0
Merge branch 'prebid:master' into master
john-ivan Jun 29, 2022
c967394
Merge branch 'master' of https://github.com/gumgum/Prebid.js
john-bauzon-gumgum Jul 26, 2022
f967526
updated skins parameter for consistency
john-bauzon-gumgum Jul 26, 2022
b30d2d2
updated test for updated skins parameter
john-bauzon-gumgum Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/gumgumBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ function buildRequests(validBidRequests, bidderRequest) {
data.pi = 5;
} else if (mediaTypes.video) {
data.pi = mediaTypes.video.linearity === 2 ? 6 : 7; // invideo : video
} else if (params.product && params.product.toLowerCase() === 'skin') {
} else if (params.product && params.product.toLowerCase() === 'skins') {
patmmccann marked this conversation as resolved.
Show resolved Hide resolved
data.pi = 8;
}
} else { // legacy params
Expand Down
6 changes: 3 additions & 3 deletions modules/gumgumBidAdapter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Maintainer: [email protected]

GumGum adapter for Prebid.js
Please note that both video and in-video products require a mediaType of video.
In-screen, slot, and skin products should have a mediaType of banner.
In-screen, slot, and skins products should have a mediaType of banner.

# Test Parameters
```
Expand Down Expand Up @@ -51,7 +51,7 @@ var adUnits = [
}
]
},{
code: 'skin-placement',
code: 'skins-placement',
sizes: [[300, 50]],
mediaTypes: {
banner: {
Expand All @@ -63,7 +63,7 @@ var adUnits = [
bidder: 'gumgum',
params: {
zone: 'dc9d6be1', // GumGum Zone ID given to the client
product: 'skin',
product: 'skins',
bidfloor: 0.03 // CPM bid floor
}
}
Expand Down
4 changes: 2 additions & 2 deletions test/spec/modules/gumgumBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,8 +279,8 @@ describe('gumgumAdapter', function () {
const bidRequest = spec.buildRequests([request])[0];
expect(bidRequest.data.pi).to.equal(3);
});
it('should set the correct pi param if product param is found and is equal to skin', function () {
const request = { ...bidRequests[0], params: { ...zoneParam, product: 'Skin' } };
it('should set the correct pi param if product param is found and is equal to skins', function () {
const request = { ...bidRequests[0], params: { ...zoneParam, product: 'Skins' } };
const bidRequest = spec.buildRequests([request])[0];
expect(bidRequest.data.pi).to.equal(8);
});
Expand Down