-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Adapter: VisibleMeasuresx #4312
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
coppa_supported: true | ||
schain_supported: true | ||
floors_supported: true | ||
media_types: banner, video, native |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have multi format support, I would strongly recommend to add multiformat_supported
(will-bid-on-any, will-bid-on-one, will-not-bid) as a meta data field, so publishers and sales houses know how you handle multi format.
safeframes_ok
is also a very helpful meta information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That data was added
|
||
### Note | ||
|
||
For the prebid server and prebid.js you only need to use one parameter: either placementId or endpointId |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it doesn't matter, I would recommend you specify one as required
and the others as optional. This is a little confusing for users of your adapter 😉
Also an example is always nice. Maybe you have a test placementId
that a dev can tinker around with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, but in our case we need one of two necessarily, but it doesn't matter which one
* add VisibleMeasures adapter * add meta data
No description provided.