Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Adapter: VisibleMeasuresx #4312

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Conversation

VisibleMeasuresHB
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Jan 31, 2023

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 89f4228
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/63ebb62ae590ba00075cccaa
😎 Deploy Preview https://deploy-preview-4312--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

coppa_supported: true
schain_supported: true
floors_supported: true
media_types: banner, video, native
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have multi format support, I would strongly recommend to add multiformat_supported (will-bid-on-any, will-bid-on-one, will-not-bid) as a meta data field, so publishers and sales houses know how you handle multi format.

safeframes_ok is also a very helpful meta information.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That data was added


### Note

For the prebid server and prebid.js you only need to use one parameter: either placementId or endpointId
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it doesn't matter, I would recommend you specify one as required and the others as optional. This is a little confusing for users of your adapter 😉

Also an example is always nice. Maybe you have a test placementId that a dev can tinker around with.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but in our case we need one of two necessarily, but it doesn't matter which one

@fowler446 fowler446 merged commit d5a69b0 into prebid:master Mar 6, 2023
ecdrsvc pushed a commit to ecdrsvc/prebid.github.io that referenced this pull request Sep 6, 2023
* add VisibleMeasures adapter

* add meta data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants