Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Adapter: VisibleMeasuresx #4312

Merged
merged 2 commits into from
Mar 6, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions dev-docs/bidders/visiblemeasures.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
---
layout: bidder
title: VisibleMeasures
description: Prebid VisibleMeasures Bidder Adapter
biddercode: visiblemeasures
usp_supported: true
gdpr_supported: true
coppa_supported: true
schain_supported: true
floors_supported: true
media_types: banner, video, native
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have multi format support, I would strongly recommend to add multiformat_supported (will-bid-on-any, will-bid-on-one, will-not-bid) as a meta data field, so publishers and sales houses know how you handle multi format.

safeframes_ok is also a very helpful meta information.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That data was added

multiformat_supported: will-not-bid
pbjs: true
pbs: true
pbs_app_supported: true
safeframes_ok: true
sidebarType: 1
---

### Bid Params

{: .table .table-bordered .table-striped }
| Name | Scope | Description | Example | Type |
|---------------|----------|-----------------------|-----------|-----------|
| `placementId` | optional | Placement Id | `'0'` | `'string'` |
| `endpointId` | optional | Endpoint Id | `'0'` | `'string'` |

### Note

For the prebid server and prebid.js you only need to use one parameter: either placementId or endpointId
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it doesn't matter, I would recommend you specify one as required and the others as optional. This is a little confusing for users of your adapter 😉

Also an example is always nice. Maybe you have a test placementId that a dev can tinker around with.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but in our case we need one of two necessarily, but it doesn't matter which one