Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3D case support capability for serial FSI cases #133

Merged
merged 18 commits into from
Feb 7, 2022

Conversation

IshaanDesai
Copy link
Member

@IshaanDesai IshaanDesai commented Jun 22, 2021

This PR adds 3D case handling capability to the adapter. Currently only 3D FSI serial cases are tested. The testing is done with the help of the elastic-tube-3d case: precice/tutorials#222. Closes #1

@IshaanDesai IshaanDesai changed the title Add 3D case support capability Add 3D case support capability for serial FSI cases Jul 5, 2021
@IshaanDesai IshaanDesai marked this pull request as ready for review July 6, 2021 07:43
@IshaanDesai IshaanDesai self-assigned this Jul 7, 2021
@IshaanDesai IshaanDesai added the enhancement New feature or request label Jul 7, 2021
@precice-bot
Copy link

This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there:

https://precice.discourse.group/t/does-the-fenics-adapter-support-3d-case/696/2

Copy link
Member

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments mainly on code quality. I did not try to run the code.

General comment: We also need tests for 3d. This is even more important than for 2d, because I expect that the 3d feature will not be used as frequently as 2d and we still want to be sure that it does not break over time.

fenicsprecice/adapter_core.py Outdated Show resolved Hide resolved
fenicsprecice/adapter_core.py Outdated Show resolved Hide resolved
fenicsprecice/adapter_core.py Outdated Show resolved Hide resolved
fenicsprecice/fenicsprecice.py Outdated Show resolved Hide resolved
fenicsprecice/fenicsprecice.py Show resolved Hide resolved
fenicsprecice/adapter_core.py Outdated Show resolved Hide resolved
@BenjaminRodenberg BenjaminRodenberg added this to the v1.3.0 milestone Jan 26, 2022
Copy link
Member

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good and I think it was really helpful to split this larger feature up into smaller PRs. There are actually only a few changes here.

I still have to check the sibling case precice/tutorials#222.

Only critical point I see is that Expressions are not supported yet. I understand that handling expressions correctly in 3D is tricky, because the way how we are constructing the interpolant is mostly manual and therefore implementing this in 3D is challenging. Maybe this is also a good hint that we should start looking for a more general strategy, such as #119.

fenicsprecice/adapter_core.py Outdated Show resolved Hide resolved
fenicsprecice/fenicsprecice.py Show resolved Hide resolved
fenicsprecice/fenicsprecice.py Outdated Show resolved Hide resolved
fenicsprecice/fenicsprecice.py Show resolved Hide resolved
@IshaanDesai IshaanDesai deleted the implement-3D branch February 7, 2022 09:20
@IshaanDesai IshaanDesai mentioned this pull request Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Support 3D cases
3 participants