Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.3.0 #150

Merged
merged 14 commits into from
Feb 8, 2022
Merged

Release v1.3.0 #150

merged 14 commits into from
Feb 8, 2022

Conversation

IshaanDesai
Copy link
Member

BenjaminRodenberg and others added 11 commits November 30, 2021 11:13
* updating fenicsprecice.py; passing relative path to config

* updating config.py; correction to the path

* updating github workflow

* Revert "updating github workflow"

This reverts commit 9b79a4b.

* updating fenicsprecice.py; merging relative path to the config instantiation
This removes the citing information for preCICE and instead links to citing information on the preCICE homepage. This avoids duplication of information. If the the citation information is updated on the homepage, we might forget to do update the README as well. Also restructure citation information to make it more verbose.
Fix list formatting in citation section (asterisk instead of dashes for list items).
…niCS (#147)

* Generalize functions related to extracting vertex information from FEniCS

* Changing to iteratable variable range(dims)
* Improving CouplingExpression class

* autopep8 formatting correction

* Add assertion to check incorrect dimensions in expression coods

* Removing 3D implementation from expression_core.py
… for 3D cases (#146)

* Improving and generalizing get_forces_as_point_sources

* Adding assertion to check dimensions of input nodal data

* Unpack component-wise force values in return statement

* [WIP] Add test for get_point_sources 2D

* [WIP] Attempt at test which applies point sources on system RHS

* Fix test.

* Fix format.

Co-authored-by: Benjamin Rodenberg <[email protected]>
* Initial un-tested design for 3D FEniCS cases

* autopep8 formatting checks

* Filter duplicate DoFs

* Filtering DoFs which are on the coupling interface

* Code refactoring to avoid parallel initialization for serial cases

* 3D function_space is identified as VECTOR FunctionType

* Rectify error in generating PointSource

* autopep8 formatting correction

* Remove unnecessary import

* Introducing changes which handle dimentionality in a generic way

* Add assertions to safeguard against use of FEniCS Expression type boundary conditions in 3D cases

* Checking if read and write functions passed are of the correct dimensions
@IshaanDesai IshaanDesai self-assigned this Feb 8, 2022
Copy link
Member

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one minor change required in the CHANGELOG.md.

Rest looks good 👍

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Member

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine 👍

@IshaanDesai IshaanDesai merged commit b8e65ac into master Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

4 participants