-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.3.0 #150
Merged
Merged
Release v1.3.0 #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updating fenicsprecice.py; passing relative path to config * updating config.py; correction to the path * updating github workflow * Revert "updating github workflow" This reverts commit 9b79a4b. * updating fenicsprecice.py; merging relative path to the config instantiation
This removes the citing information for preCICE and instead links to citing information on the preCICE homepage. This avoids duplication of information. If the the citation information is updated on the homepage, we might forget to do update the README as well. Also restructure citation information to make it more verbose.
Fix list formatting in citation section (asterisk instead of dashes for list items).
…niCS (#147) * Generalize functions related to extracting vertex information from FEniCS * Changing to iteratable variable range(dims)
* Improving CouplingExpression class * autopep8 formatting correction * Add assertion to check incorrect dimensions in expression coods * Removing 3D implementation from expression_core.py
… for 3D cases (#146) * Improving and generalizing get_forces_as_point_sources * Adding assertion to check dimensions of input nodal data * Unpack component-wise force values in return statement * [WIP] Add test for get_point_sources 2D * [WIP] Attempt at test which applies point sources on system RHS * Fix test. * Fix format. Co-authored-by: Benjamin Rodenberg <[email protected]>
* Initial un-tested design for 3D FEniCS cases * autopep8 formatting checks * Filter duplicate DoFs * Filtering DoFs which are on the coupling interface * Code refactoring to avoid parallel initialization for serial cases * 3D function_space is identified as VECTOR FunctionType * Rectify error in generating PointSource * autopep8 formatting correction * Remove unnecessary import * Introducing changes which handle dimentionality in a generic way * Add assertions to safeguard against use of FEniCS Expression type boundary conditions in 3D cases * Checking if read and write functions passed are of the correct dimensions
BenjaminRodenberg
requested changes
Feb 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one minor change required in the CHANGELOG.md
.
Rest looks good 👍
BenjaminRodenberg
approved these changes
Feb 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_forces_as_point_sources
#146 and Generalize functions related to extracting vertex information from FEniCS #147