Fix broken Storybook build by upgrading Storybook Jest-related deps #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigpalermo
force-pushed
the
fix-storybook-build-2
branch
3 times, most recently
from
a05fd3f
to
bb1c596
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1393 +/- ##
=======================================
Coverage 95.63% 95.63%
=======================================
Files 203 203
Lines 2431 2431
Branches 464 464
=======================================
Hits 2325 2325
Misses 51 51
Partials 55 55 ☔ View full report in Codecov by Sentry. |
sdalonzo
approved these changes
Sep 5, 2023
craigpalermo
force-pushed
the
fix-storybook-build-2
branch
from
bb1c596
to
45c0e55
Compare
DerrickTheodore
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix in
@testing-library/jest-domwe needed: testing-library/jest-dom#519. This required updating@storybook/jestso it would also use the latest version.Root cause: storybookjs/jest#15