Publish ESM and CJS

[IanVS]

What:

This is a re-implementation of #438 and #453 which upgrades the build command to generate both esm and cjs bundles, for each of the entry files now exposed in 6.0 (index, matchers, jest-global, and vitest).

Closes #498

Why:

Closes #437

How:

I replaced kcd-scripts with rollup, configured to generate esm and cjs bundles.

I added exports to the package.json to support these multiple exports, but lied slightly in the types field, since we only have one type definition for both cjs and esm, when technically we should have two, one for each format. But, since we're not actually generating these definitions from typescript files, I think this should be fine, and we can adjust it in the future if/when the project is converted to TS itself.

I added files in src for vitest and jest-global, from which to build. They are very similar to the files in the root, which will still be used by bundlers/typescript configurations which do not support package.json exports.

I tested this out in a typescript vitest project, using both node and node16 moduleResolution. I needed to add extensions to lodash imports to support Node16.

It would be excellent if @jgoz could review/test for jest-global support, since it's been a while since I've set up a jest project.

Checklist:

• Documentation N/A
• Tests N/A
• Updated Type Definitions N/A
• Ready to be merged
  

I don't anticipate that this would require a breaking release, as it should continue to work as before.

[codecov]

Codecov Report

Merging #519 (d494ce4) into main (bdb34f1) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #519   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines          664       664           
  Branches       251       251           
=========================================
  Hits           664       664           

Files Changed	Coverage Δ
src/to-have-form-values.js	100.00% <ø> (ø)
src/to-have-value.js	100.00% <ø> (ø)
src/utils.js	100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[nickserv]

Thanks for looking into this. Do you think it would be easy to upstream a generic solution for this into kcd-scripts? Then we could still have the fix here, but it should also be easier to use in other Testing Library packages.

[jgoz]

I tested these changes locally with Jest, @jest/globals, and vitest with various TypeScript/module resolution settings and they all seemed to work. 🎉

(I'm planning to move my example projects into this repo once I get back from vacation, which should help users and maintainers).

[jgoz]

Out of curiosity, when would an import start with \0?

[IanVS]

It is a convention for rollup plugins that create virtual modules. https://rollupjs.org/plugin-development/#conventions

We don't have any such plugins enabled here, so it could probably be removed if desired, but I kept it just to be safe. Honestly I don't remember writing this originally, I may have copied it from somewhere else that suggested it.

[jgoz]

Thanks for the explanation. It's probably fine to keep in, I just haven't used rollup in several years and it stuck out to me. Esbuild has the convenient packages=external option and Rollup doesn't appear to have anything similar.

[IanVS]

Thanks for looking into this. Do you think it would be easy to upstream a generic solution for this into kcd-scripts?

I'm not very familiar with kcd-scripts, but when I looked into it before, it relied on babel and didn't seem to be super-flexible in that regard. But I can spend some time looking into it. Though, it might be nice to publish this first, as a bit of a canary, then extend the approach to kcd-scripts after it's been battle tested by users a bit.

[jgoz]

Thanks @IanVS! I have no opinion on upstreaming these changes into kcd-scripts, but publishing this as a canary makes sense.

[jgoz]

Hmm, I assumed the chore scope would trigger a release, but apparently it does not...

[jgoz]

Maybe someone else with push access could approve #520 so these changes can get published?

[nickserv]

Thanks for looking into this. Do you think it would be easy to upstream a generic solution for this into kcd-scripts?

I'm not very familiar with kcd-scripts, but when I looked into it before, it relied on babel and didn't seem to be super-flexible in that regard. But I can spend some time looking into it. Though, it might be nice to publish this first, as a bit of a canary, then extend the approach to kcd-scripts after it's been battle tested by users a bit.

kcd-scripts is also based on Rollup, so this should be feasible. I wouldn't be against removing Babel, though it is possible to use them together.

[github-actions]

🎉 This PR is included in version 6.1.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀