Remove the environmental awareness feature #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the way cargo works .veil.toml can't impact other crates consistently. This reverts commit 69dd762.
WilliamVenner
suggested changes
Sep 22, 2022
This is a simpler replacement for the environmental awareness feature.
MaeIsBad
force-pushed
the
mae/remove-env-awareness
branch
from
87c40e2
to
9ee7096
Compare
This is neccessary because rust runs all tests in the same process, leading to tests failing randomly, because of other tests modifying the global state. There is some proposal on the rust compiler-team github repo but until that gets stabilized we have to use this hack instead rust-lang/compiler-team#508
Co-authored-by: William <[email protected]>
Ensure that the use of this feature requires a very explicit opt-in from the user.
WilliamVenner
suggested changes
Sep 22, 2022
MaeIsBad
force-pushed
the
mae/remove-env-awareness
branch
from
e1c9ce6
to
939cf95
Compare
* Rename it to veil-tests-disable-redaction * Set publish = false * Change the outer line doc comment describing the test into a inner line doc comment
MaeIsBad
force-pushed
the
mae/remove-env-awareness
branch
from
939cf95
to
01687e5
Compare
This avoids repeating that the disable function needs the toggle feature flag which makes it clearer that the VEIL_DISABLE_REDACTION envar also needs the feature flag
WilliamVenner
suggested changes
Sep 23, 2022
Co-authored-by: William <[email protected]>
Make it clear that to skip redacting data the user needs to either call the disable function *or* set the VEIL_DISABLE_REDACTION variable, not both.
WilliamVenner
approved these changes
Sep 26, 2022
|
Oh yeah!!! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the environmental awareness feature, which due to the limitations of cargo didn't work with dependencies, and replaces it with a simple
set_debug_formatfunction.TODOs:
VEIL_DISABLE_REDACTIONvariableNot using the standard workflow, because I don't have access to youtrack, sorry!