Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the environmental awareness feature #16

Merged
merged 15 commits into from
Sep 26, 2022

Commits on Sep 22, 2022

  1. Revert "Add redaction control based on environment variables (#7)"

    Due to the way cargo works .veil.toml can't impact other crates
    consistently.
    
    This reverts commit 69dd762.
    MaeIsBad committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    d9df3af View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3135016 View commit details
    Browse the repository at this point in the history
  3. Add a set_debug_format function

    This is a simpler replacement for the environmental awareness feature.
    MaeIsBad committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    30520c0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9ee7096 View commit details
    Browse the repository at this point in the history
  5. Move tests that disable redaction into a separate crate

    This is neccessary because rust runs all tests in the same process,
    leading to tests failing randomly, because of other tests modifying the
    global state. There is some proposal on the rust compiler-team github
    repo but until that gets stabilized we have to use this hack instead
    rust-lang/compiler-team#508
    MaeIsBad committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    dd9c3ee View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0efc786 View commit details
    Browse the repository at this point in the history
  7. Hide the disable feature behind a feature flag

    Ensure that the use of this feature requires a very explicit opt-in from
    the user.
    MaeIsBad committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    643c528 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c1e9b72 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2022

  1. Configuration menu
    Copy the full SHA
    55db438 View commit details
    Browse the repository at this point in the history
  2. Minor fixes to disable-redaction-test

    * Rename it to veil-tests-disable-redaction
    * Set publish = false
    * Change the outer line doc comment describing the test into a inner
      line doc comment
    MaeIsBad committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    01687e5 View commit details
    Browse the repository at this point in the history
  3. Improve the disable veil redaction docs

    This avoids repeating that the disable function needs the toggle feature
    flag which makes it clearer that the VEIL_DISABLE_REDACTION envar also
    needs the feature flag
    MaeIsBad committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    b820a32 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2022

  1. Clarify RedactionBehavior doc comment

    Co-authored-by: William <[email protected]>
    MaeIsBad and WilliamVenner authored Sep 26, 2022
    Configuration menu
    Copy the full SHA
    e9a5ff9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b61b10a View commit details
    Browse the repository at this point in the history
  3. Update README.md

    Make it clear that to skip redacting data the user needs to either call
    the disable function *or* set the VEIL_DISABLE_REDACTION variable, not
    both.
    MaeIsBad committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    2738c5c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1e073aa View commit details
    Browse the repository at this point in the history