Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar: closeOnEscape not working #11517

Closed
anikets43 opened this issue May 12, 2022 · 0 comments · Fixed by #11520
Closed

Sidebar: closeOnEscape not working #11517

anikets43 opened this issue May 12, 2022 · 0 comments · Fixed by #11520
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@anikets43
Copy link

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
https://stackblitz.com/edit/primeng-sidebar-demo

Current behavior
Sidebar component's property closeOnEscape doesn't work. It's value is marked as true by default(here )

Issue could be here

Expected behavior
Sidebar should close when Esc is pressed provided closeOnEscape is not set explicitly to false

  • Angular version: 13.3.1
  • PrimeNG version: 13.4
  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
  • Language: [all | TypeScript X.X | ES6/7 | ES5]

  • Node (for AoT issues): node --version = 14.17.0

volvachev pushed a commit to volvachev/primeng that referenced this issue May 13, 2022
volvachev added a commit to volvachev/primeng that referenced this issue May 13, 2022
@cetincakiroglu cetincakiroglu self-assigned this May 23, 2022
@cetincakiroglu cetincakiroglu added Status: Pending Review Issue or pull request is being reviewed by Core Team Type: Bug Issue contains a bug related to a specific component. Something about the component is not working labels May 23, 2022
@cetincakiroglu cetincakiroglu added this to the 13.Future milestone May 23, 2022
@cetincakiroglu cetincakiroglu removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label May 23, 2022
@cetincakiroglu cetincakiroglu modified the milestones: 13.Future, 13.4.2 May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants