Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SideBar | update closeOnEscape option #11520

Merged
merged 1 commit into from
May 24, 2022
Merged

SideBar | update closeOnEscape option #11520

merged 1 commit into from
May 24, 2022

Conversation

volvachev
Copy link
Contributor

Fixes #11517.

@volvachev
Copy link
Contributor Author

@cetincakiroglu, Hi could you do a review of the pull request?

@mertsincan
Copy link
Member

Hi @volvachev, Great PR! Thanks a lot for your contribution!

@cetincakiroglu cetincakiroglu changed the title fix(primeng/sidebar): handle closeOnEscape option SideBar | update closeOnEscape option May 24, 2022
@cetincakiroglu cetincakiroglu merged commit 35995a4 into primefaces:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cetincakiroglu cetincakiroglu cetincakiroglu approved these changes

@mertsincan mertsincan Awaiting requested review from mertsincan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sidebar: closeOnEscape not working
3 participants
@volvachev @mertsincan @cetincakiroglu