Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button: loading state bugs #13098

Closed
itismohammadreza opened this issue May 25, 2023 · 0 comments · Fixed by #13209
Closed

Button: loading state bugs #13098

itismohammadreza opened this issue May 25, 2023 · 0 comments · Fixed by #13209
Labels
LTS-FIXED-15.4.5 Fixed in PrimeNG LTS 15.4.5 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
16.0.1

Comments

@itismohammadreza
Copy link
Contributor

itismohammadreza commented May 25, 2023 •
edited
Loading

Describe the bug

1- For a button that already has an icon, it has no margin (between label and loading icon) when it enters to loading state. becuase the space will apply only via p-button-label-only css class.
2- The descibed margin (in case 1) applies just for left icon position.
2- When we give the icon through component's @input, it is not applied and sticks to the previous class names.
3- loadinIcon property is not apply anywhere.

Untitled

Output:
Screenshot 2023-06-03 112338

PrimeNG version

16.0.0
@itismohammadreza itismohammadreza added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 25, 2023
volvachev added a commit to volvachev/primeng that referenced this issue Jun 16, 2023
@volvachev
fix(primeng/p-button): not working loadingIcon property, update loa…
849853c 
…dingdoc example

Fixes primefaces#13098.
volvachev added a commit to volvachev/primeng that referenced this issue Jun 16, 2023
@volvachev
fix(primeng/p-button): not working loadingIcon property, update loa…
0c8cdd6 
…dingdoc example

Fixes primefaces#13098.
@volvachev volvachev mentioned this issue Jun 16, 2023
Merged
@cetincakiroglu cetincakiroglu added this to the 16.0.1 milestone Jun 16, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jun 16, 2023
@gucal gucal added the LTS-FIXED-15.4.5 Fixed in PrimeNG LTS 15.4.5 label Jun 19, 2023
steve3d pushed a commit to steve3d/primeng that referenced this issue Aug 28, 2023
@volvachev @steve3d
fix(primeng/p-button): not working loadingIcon property, update loa…
63066f3 
…dingdoc example

Fixes primefaces#13098.
mertsincan pushed a commit that referenced this issue Aug 29, 2023
@steve3d @volvachev
@cetincakiroglu @gucal @barais
feat: Add custom style class to p-table p-dataview p-treeview (#13205)
6069219 
* feat: Add custom style class to p-table/p-dataview/p-treeview

* fix(primeng/p-button): spinner style not working propely

Fixes #13148.

* Fixed #13183 - Make TreeNode generic

* Fix: Icon list visibility

* fix(primeng/p-menu): render html via `DomSanitizer`

Fixes #13128.

* fix(primeng/p-button): not working `loadingIcon` property, update loadingdoc example

Fixes #13098.

* fix: update angular version restriction

* fix(primeng/p-confirmDialog): not updated style in runtime

Fixes #13155.

* Fix #13129 - FileUpload | File limit does not fire error

* Fix #13201 - OverlayPanel: Incorrect position when inside of dialog in 16.0.0 (did not happen in rc2)

* Fix - Surface color list

* fix #13124

---------

Co-authored-by: Egor Volvachev <[email protected]>
Co-authored-by: Çetin <[email protected]>
Co-authored-by: gucal <[email protected]>
Co-authored-by: Olivier Barais <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
LTS-FIXED-15.4.5 Fixed in PrimeNG LTS 15.4.5 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
16.0.1
Development

Successfully merging a pull request may close this issue.

fix(primeng/p-button): not working loadingIcon property, update loadingdoc example volvachev/primeng
3 participants
@gucal @itismohammadreza @cetincakiroglu