Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OverlayPanel: Incorrect position when inside of dialog in 16.0.0 (did not happen in rc2) #13201

Closed
gabboman opened this issue Jun 14, 2023 · 3 comments · Fixed by #13215
Closed
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@gabboman
Copy link

Describe the bug

The overlay panel does not go to the correct place with the latest stable version. This issue did not happen in the RC2.

I attach screenshot of the issue:

Expected behaivour (screenshot taken with RC2)
Captura de pantalla 2023-06-14 a las 9 56 19

Current behaivour with 16.0.0
Captura de pantalla 2023-06-14 a las 9 56 29

This issue is more than a visual annoyance in mobile devices: in my iphone SE 2020 (iphone 8 screen basically) does not even appears.

Environment

This is my package json
{
"name": "wafrn",
"version": "0.0.2",
"scripts": {
"ng": "ng",
"start": "ng serve",
"build": "ng build",
"watch": "ng build --watch --configuration development",
"test": "ng test",
"dev:ssr": "ng run wafrn:serve-ssr",
"serve:ssr": "node dist/wafrn/server/main.js",
"build:ssr": "ng build && ng run wafrn:server",
"prerender": "ng run wafrn:prerender",
"vercel-build": "npm run build:ssr"
},
"private": true,
"dependencies": {
"@angular/animations": "^16.0.0",
"@angular/cdk": "^16.0.0",
"@angular/common": "^16.0.0",
"@angular/compiler": "^16.0.0",
"@angular/core": "^16.0.0",
"@angular/elements": "^16.0.0",
"@angular/forms": "^16.0.0",
"@angular/platform-browser": "^16.0.0",
"@angular/platform-browser-dynamic": "^16.0.0",
"@angular/platform-server": "^16.0.0",
"@angular/router": "^16.0.0",
"@typescript-eslint/parser": "^5.9.1",
"core-js": "^3.25.3",
"eslint": "^8.7.0",
"eslint-config-google": "^0.14.0",
"ngx-quill": "^22.0.0",
"notosans-fontface": "^1.3.0",
"primeflex": "^3.3.0",
"primeicons": "^6.0.1",
"primeng": "^16.0.0",
"quill-mention": "^3.1.0",
"rxjs": "^7.8.1",
"sanitize-html": "^2.10.0",
"zone.js": "~0.13.0"
},
"devDependencies": {
"@angular-devkit/build-angular": "^16.0.0",
"@angular/cli": "16.0.0",
"@angular/compiler-cli": "^16.0.0",
"@types/express": "^4.17.0",
"@types/jasmine": "~3.10.0",
"@types/node": "^18.14.1",
"@types/quill": "^1.3.10",
"@types/sanitize-html": "^2.6.2",
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-prettier": "^4.0.0",
"jasmine-core": "~3.10.0",
"karma": "~6.3.14",
"karma-chrome-launcher": "~3.1.0",
"karma-coverage": "~2.1.0",
"karma-jasmine": "~4.0.0",
"karma-jasmine-html-reporter": "~1.7.0",
"prettier": "^2.5.1",
"tslib": "^2.4.0",
"typescript": "~5.0.4"
}
}

Reproducer

No response

Angular version

16.0.0

PrimeNG version

16.0.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.14.1

Browser(s)

No response

Steps to reproduce the behavior

Put something on a dialog, add overlay panel to it. display overlay panel.

Overlay panel appears on wrong position

Expected behavior

to happen like in the RC version. This issue is a regression

@gabboman gabboman added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 14, 2023
@gucal gucal added this to the 16.0.1 milestone Jun 14, 2023
@gucal gucal added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jun 14, 2023
@dougmbarcellos
Copy link

Try this workaround:

appendTo="body"

@gabboman
Copy link
Author

Hello @dougmbarcellos it works after adding this. Is this a regression or is it an issue on my side?

@dougmbarcellos
Copy link

Hello @dougmbarcellos it works after adding this. Is this a regression or is it an issue on my side?

It's a problem in primeng.

The solution is from the following comment #13191 (comment)

@gucal gucal self-assigned this Jun 16, 2023
gucal added a commit that referenced this issue Jun 16, 2023
cetincakiroglu added a commit that referenced this issue Jun 16, 2023
Fix #13201 - OverlayPanel: Incorrect position when inside of dialog i…
steve3d pushed a commit to steve3d/primeng that referenced this issue Aug 28, 2023
…f dialog in 16.0.0 (did not happen in rc2)
mertsincan pushed a commit that referenced this issue Aug 29, 2023
* feat: Add custom style class to p-table/p-dataview/p-treeview

* fix(primeng/p-button): spinner style not working propely

Fixes #13148.

* Fixed #13183 - Make TreeNode generic

* Fix: Icon list visibility

* fix(primeng/p-menu): render html via `DomSanitizer`

Fixes #13128.

* fix(primeng/p-button): not working `loadingIcon` property, update loadingdoc example

Fixes #13098.

* fix: update angular version restriction

* fix(primeng/p-confirmDialog): not updated style in runtime

Fixes #13155.

* Fix #13129 - FileUpload | File limit does not fire error

* Fix #13201 - OverlayPanel: Incorrect position when inside of dialog in 16.0.0 (did not happen in rc2)

* Fix - Surface color list

* fix #13124

---------

Co-authored-by: Egor Volvachev <[email protected]>
Co-authored-by: Çetin <[email protected]>
Co-authored-by: gucal <[email protected]>
Co-authored-by: Olivier Barais <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants