Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When RadioButton is selected, clicking on it does not trigger the onClick event. #5610

Closed
Traveller23 opened this issue Dec 18, 2023 · 0 comments · Fixed by #5614
Closed

When RadioButton is selected, clicking on it does not trigger the onClick event. #5610

Traveller23 opened this issue Dec 18, 2023 · 0 comments · Fixed by #5614
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.3.0

Comments

@Traveller23
Copy link

Traveller23 commented Dec 18, 2023 •
edited
Loading

Describe the bug

1

Clicking on a selected item does not trigger the onClick event.
This makes it impossible to write code to cancel the current selection.

Reproducer

https://codesandbox.io/p/sandbox/radio-bux-7m27iq-forked-pyjt4y?file=%2Fsrc%2Fdemo%2FRadioButtonDemo.tsx%3A17%2C1

PrimeReact version

10.2.1

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

Chrome 120

Steps to reproduce the behavior

No response

Expected behavior

No response
@Traveller23 Traveller23 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 18, 2023
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 18, 2023
melloware added a commit to melloware/primereact that referenced this issue Dec 18, 2023
@melloware
Fix primefaces#5610: Radio/Checkbox always fire onClick
f9184e9
@melloware melloware self-assigned this Dec 18, 2023
@melloware melloware added this to the 10.2.2 milestone Dec 18, 2023
@melloware melloware mentioned this issue Dec 18, 2023
Merged
melloware added a commit that referenced this issue Dec 18, 2023
@melloware
Fix #5610: Radio/Checkbox always fire onClick (#5614)
85e69a5
melloware added a commit to melloware/primereact that referenced this issue Jan 9, 2024
@melloware
Fix primefaces#5610: Radio/Checkbox always fire onClick
5c5ebb1
melloware added a commit that referenced this issue Jan 9, 2024
@melloware
Port fixes5 (#5713)
98c5b0d 
* Fix #5485: Messages restore close animation

* Fix #5490: useDebounce fixed

* Fix #5492: Listbox passthrough fixes

* Fix #5493: Multiselect passthrough fixes

* Fix #5485: Messages restore close animation

* Fix #5499: Autocomplete/Chips PT fixes

* Fix #5479: CascadeSelect PT fixes

* Fix #5509: Button loadingIcon Tailwind fix

* Fix #5512: Dropdown add tabindex for Tailwind

* Support roundingMode for InputNumber

* Fix #5523: BlockUI return activeElement focus

* Fix #5530: Chip onRemove event pass value

* DataTable:converted to data- lookups instead of className lookups

* Fix #5543: OverlayPanel Tailwind close icon

* Fix #5546: prop type error in console

* Fix #5555: BodyCell frozen issue

* Fix #5561: Inplace respect active prop

* Fix #5568: MultiSelect filterInput PT

* Fix #5572: Multselect selectAllLabel was being added to DOM

* Tooltip fix Tailwind CSS

* Dialog Breakpoints

* Calendar disabled date handling

* Fix #5609: ToggleButton focusedState

* Fix #5610: Radio/Checkbox always fire onClick

* fix: #5613, TreeSelect: TreeSelect component is not supporting tooltips and is an issue in multiple select mode

* Fix #5623 - Otherprops not working for InputSwitch

* fix:Calendar not showing correctly in Table

* fix:Image preview zoom in bug

* Fix #5637: Sidebar aria-label close

* Accept array as PT value

* Datatable breakpoints

* fix:ConfirmDialog: acceptButton's pt don't respect button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.3.0
Development

Successfully merging a pull request may close this issue.

Fix #5610: Radio/Checkbox always fire onClick melloware/primereact
2 participants
@melloware @Traveller23