Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SideBar: aria-label disappear on close button #5637

Closed
arnodemer opened this issue Dec 22, 2023 · 2 comments · Fixed by #5638
Closed

SideBar: aria-label disappear on close button #5637

arnodemer opened this issue Dec 22, 2023 · 2 comments · Fixed by #5638
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.3.0

Comments

@arnodemer
Copy link
Contributor

Describe the bug

'aria-label'='close' disppear between primereact v8 => v9
I didn't find any existing issue on this, then I create this one, and hope this can be fixed in v11 release, thanks !

Reproducer

No response

PrimeReact version

v9.x.x, v10.x.x

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

  1. open primereact v8 Sidebar component: https://www.primefaces.org/primereact-v8/sidebar/

  2. open sidebar

  3. right click on close button
    4 select 'Inspect element'
    => aria-label is there:
    image

  4. open primereact v9 or v10 Sidebar component: https://v9.primereact.org/sidebar/

  5. open sidebar

  6. right lick on close button

  7. select 'Inspect element'
    => aria-label attribute has disappeared
    image

Expected behavior

It might be not the only location where aria-label and other aria attribute has disappeared (I didn't check for dialog component ...)
I know you make big effort on release v11 to fix most of the accessibility issues, hope this one will be part of this release.
Thanks
@arnodemer arnodemer added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 22, 2023
@melloware melloware self-assigned this Dec 22, 2023
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 22, 2023
@melloware melloware added this to the 10.2.2 milestone Dec 22, 2023
melloware added a commit to melloware/primereact that referenced this issue Dec 22, 2023
@melloware
Fix primefaces#5637: Sidebar aria-label close
8a8ab51
@melloware melloware mentioned this issue Dec 22, 2023
Merged
melloware added a commit that referenced this issue Dec 22, 2023
@melloware
Fix #5637: Sidebar aria-label close (#5638)
90c3134
@melloware
Copy link
Member

Thanks fixed for next release!

@arnodemer
Copy link
Contributor Author

great, thanks !

melloware added a commit to melloware/primereact that referenced this issue Jan 9, 2024
@melloware
Fix primefaces#5637: Sidebar aria-label close
482c88c
melloware added a commit that referenced this issue Jan 9, 2024
@melloware
Port fixes5 (#5713)
98c5b0d 
* Fix #5485: Messages restore close animation

* Fix #5490: useDebounce fixed

* Fix #5492: Listbox passthrough fixes

* Fix #5493: Multiselect passthrough fixes

* Fix #5485: Messages restore close animation

* Fix #5499: Autocomplete/Chips PT fixes

* Fix #5479: CascadeSelect PT fixes

* Fix #5509: Button loadingIcon Tailwind fix

* Fix #5512: Dropdown add tabindex for Tailwind

* Support roundingMode for InputNumber

* Fix #5523: BlockUI return activeElement focus

* Fix #5530: Chip onRemove event pass value

* DataTable:converted to data- lookups instead of className lookups

* Fix #5543: OverlayPanel Tailwind close icon

* Fix #5546: prop type error in console

* Fix #5555: BodyCell frozen issue

* Fix #5561: Inplace respect active prop

* Fix #5568: MultiSelect filterInput PT

* Fix #5572: Multselect selectAllLabel was being added to DOM

* Tooltip fix Tailwind CSS

* Dialog Breakpoints

* Calendar disabled date handling

* Fix #5609: ToggleButton focusedState

* Fix #5610: Radio/Checkbox always fire onClick

* fix: #5613, TreeSelect: TreeSelect component is not supporting tooltips and is an issue in multiple select mode

* Fix #5623 - Otherprops not working for InputSwitch

* fix:Calendar not showing correctly in Table

* fix:Image preview zoom in bug

* Fix #5637: Sidebar aria-label close

* Accept array as PT value

* Datatable breakpoints

* fix:ConfirmDialog: acceptButton's pt don't respect button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.3.0
Development

Successfully merging a pull request may close this issue.

Fix #5637: Sidebar aria-label close melloware/primereact
2 participants
@melloware @arnodemer