Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6357: typescript definition for ButtonGroup #6360

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

dvpritzbuer
Copy link
Contributor

Fix #6357: typescript definition for ButtonGroup (missing ref definition)

Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2024 8:07pm
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2024 8:07pm

@melloware melloware requested a review from gucal April 9, 2024 20:13
@melloware
Copy link
Member

@dvpritzbuer did you see my comment in the other one? Does this break React 17 compatibility?

@melloware melloware added Status: Pending Review Issue or pull request is being reviewed by Core Team Typescript Issue or pull request is *only* related to TypeScript definition labels Apr 9, 2024
@melloware
Copy link
Member

we should probably look at a lot of our other Typescript that uses children instead of this way...

@melloware melloware removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label Apr 12, 2024
@melloware
Copy link
Member

@dvpritzbuer see this convo: #6388

@gucal gucal merged commit 3c3c64d into primefaces:master Apr 15, 2024
6 checks passed
@dvpritzbuer dvpritzbuer deleted the issue-6357 branch April 16, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typescript Issue or pull request is *only* related to TypeScript definition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ButtonGroup: Typescript missing ref property definition
3 participants