Add missing children prop in FloatLabel.d.ts #6388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
melloware
added
the
Typescript
|
@NiclasvanEyk can you check out this PR: #6360 @dvpritzbuer thinks this is a better way to define Children? |
|
@melloware does not really matter. If you look at the react type definitions, it boils down to the same thing (also in React 17). I personally prefer the explicit way, but either way works. |
|
OK leave it the explicit way! |
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
Fixes #6387
I used the same description format as in the other components. I validated the change works by adding it to the local .d.ts file from my node_modules and it makes the example mentioned in the issue and my code compile again.