Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UnderlineNav in Safari #1042

Merged
merged 2 commits into from
Mar 24, 2020
Merged

Fix UnderlineNav in Safari #1042

merged 2 commits into from
Mar 24, 2020

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Mar 9, 2020

This fixes the gray background in UnderlineNav items when used as <button> elements in Safari.

Screen Shot 2020-03-09 at 7 02 30 PM

Reported in Slack by @tobiasahlin 🙇 ❤️

@vercel
Copy link

vercel bot commented Mar 9, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-css/6vtmylrlz
✅ Preview: https://primer-css-git-fix-underlinenav-in-safari.primer.now.sh

@simurai simurai requested a review from colinkeany March 9, 2020 10:07
colinkeany
colinkeany approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@colinkeany colinkeany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@simurai simurai changed the base branch from master to release-14.3.0 March 24, 2020 01:41
@vercel vercel bot temporarily deployed to Preview March 24, 2020 01:43 Inactive
@simurai simurai merged commit 803358e into release-14.3.0 Mar 24, 2020
@simurai simurai deleted the fix-underlinenav-in-safari branch March 24, 2020 01:43
@simurai simurai mentioned this pull request Mar 27, 2020
Merged
5 tasks
@github-actions github-actions bot mentioned this pull request Nov 28, 2022
Open
@github-actions github-actions bot mentioned this pull request Dec 14, 2022
Open
This was referenced Dec 21, 2022
Open
Open
Open
@github-actions github-actions bot mentioned this pull request Jan 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinkeany colinkeany colinkeany approved these changes

Assignees
No one assigned
Labels
patch release Tag: Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simurai @colinkeany