Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primer CSS 14.3.0 #1053

Merged
merged 25 commits into from
Mar 26, 2020
Merged

Primer CSS 14.3.0 #1053

merged 25 commits into from
Mar 26, 2020

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Mar 24, 2020 •
edited
Loading

Version: 📦 14.3.0
Approximate release date: 📆 March 25th 2020
Changes: 🎉 All merged PRs

🚀 Enhancements

  • #1044 Accessible form validation
  • #1028 Improve .form-group accessibility

🐛 Bug fixes

  • #670 Fix Box row top border
  • #1042 Fix UnderlineNav in Safari
  • #1035 Update UnderlineNav-item to not wrap counter & icon

📝 Documentation

  • #1018 Update MIGRATING.md

Committers

Ship checklist

  • Update the version field in package.json
  • Update CHANGELOG.md
  • Test the release candidate version with github/github
  • Merge this PR and create a new release
  • Update github/github

For more details, see RELEASING.md.

TODO on dotcom

  • Keep on eye on the Box top border fix
  • Test UnderlineNav
  • Consider refactoring all the .form-groups

/cc @primer/ds-core

@vercel
Copy link

vercel bot commented Mar 24, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-css/kesmn2clq
✅ Preview: https://primer-css-git-release-1430.primer.now.sh

@simurai
Merge pull request #1035 from primer/underlinenav-item-nowrap
3f3caad 
Update UnderlineNav-item to not wrap counter & icon
@vercel vercel bot temporarily deployed to Preview March 24, 2020 01:40 Inactive
@vercel vercel bot temporarily deployed to Preview March 24, 2020 01:43 Inactive
@vercel vercel bot temporarily deployed to Preview March 24, 2020 01:44 Inactive
@vercel vercel bot temporarily deployed to Preview March 24, 2020 02:06 Inactive
@vercel vercel bot temporarily deployed to Preview March 24, 2020 02:08 Inactive
@vercel vercel bot temporarily deployed to Preview March 24, 2020 03:04 Inactive
@vercel vercel bot temporarily deployed to Preview March 24, 2020 03:06 Inactive
@simurai simurai marked this pull request as ready for review March 24, 2020 03:11
@simurai simurai changed the title Primer CSS Minor Release Primer CSS 14.3.0 Mar 24, 2020
@simurai simurai merged commit c0ff60f into master Mar 26, 2020
@simurai simurai deleted the release-14.3.0 branch March 26, 2020 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@emplums emplums Awaiting requested review from emplums

@emilybrick emilybrick Awaiting requested review from emilybrick

@colinkeany colinkeany Awaiting requested review from colinkeany

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simurai @jonrohan